Add invader-hit SFX on bullet collisions in Space Invaders#443
Merged
Add invader-hit SFX on bullet collisions in Space Invaders#443
Conversation
Agent-Logs-Url: https://github.com/NextCommunity/NextCommunity.github.io/sessions/2e21a107-94cf-4f0c-8d3f-8dae8d66ef0b Co-authored-by: jbampton <418747+jbampton@users.noreply.github.com>
Agent-Logs-Url: https://github.com/NextCommunity/NextCommunity.github.io/sessions/2e21a107-94cf-4f0c-8d3f-8dae8d66ef0b Co-authored-by: jbampton <418747+jbampton@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jbampton
April 19, 2026 06:43
View session
jbampton
approved these changes
Apr 19, 2026
Copilot AI
added a commit
that referenced
this pull request
Apr 19, 2026
* Add hit sound when Space Invaders bullet destroys an invader Agent-Logs-Url: https://github.com/NextCommunity/NextCommunity.github.io/sessions/2e21a107-94cf-4f0c-8d3f-8dae8d66ef0b Co-authored-by: jbampton <418747+jbampton@users.noreply.github.com> * Clean up Web Audio nodes after invader hit sound Agent-Logs-Url: https://github.com/NextCommunity/NextCommunity.github.io/sessions/2e21a107-94cf-4f0c-8d3f-8dae8d66ef0b Co-authored-by: jbampton <418747+jbampton@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jbampton <418747+jbampton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Space Invaders currently has no hit feedback when bullets destroy invaders, making successful shots feel muted. This PR adds a short, synthesized hit sound on bullet→invader collisions.
Collision feedback wiring
Audio implementation
AudioContextto avoid per-hit context creation.Runtime cleanup
oscillator.onendedcleanup to disconnect temporary audio nodes after playback and prevent node buildup during rapid fire.