Skip to content

fix: "Directory" heading uses accent color on all themes#454

Merged
jbampton merged 8 commits intomainfrom
copilot/fix-directory-header-color
May 2, 2026
Merged

fix: "Directory" heading uses accent color on all themes#454
jbampton merged 8 commits intomainfrom
copilot/fix-directory-header-color

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 2, 2026

  • Add transition-colors to Directory <h1> (previous session)
  • Add duration-300 to Directory <h1> to match body transition duration per Gemini review

@jbampton jbampton added the good first issue Good for newcomers label May 2, 2026
@jbampton jbampton added this to Next May 2, 2026
@jbampton jbampton added this to the Turbo milestone May 2, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Next May 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a theme-specific styling issue on profile pages where the “Directory” heading color depended on --text-main (white in dark mode) and only appeared correct on hover.

Changes:

  • Update the “Directory” <h1> to use text-accent instead of text-[var(--text-main)] plus a hover override.
  • Remove the group-hover/back:text-accent class from the “Directory” heading since the accent color is now applied consistently.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/_includes/header-details.njk Outdated
@jbampton
Copy link
Copy Markdown
Member

jbampton commented May 2, 2026

/gemini review

@jbampton jbampton marked this pull request as ready for review May 2, 2026 11:10
@jbampton jbampton requested review from BaseMax and jbampton as code owners May 2, 2026 11:10
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the styling of the 'Directory' heading in the header-details template. The heading color is now set to 'text-accent' by default, and the hover-specific color transition has been removed to simplify the visual state. I have no feedback to provide as there are no review comments to evaluate.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@jbampton jbampton requested a review from Copilot May 2, 2026 11:16
@jbampton
Copy link
Copy Markdown
Member

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/_includes/header-details.njk Outdated
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the styling of the 'Directory' heading in the header details template by setting a constant accent color and removing hover-specific transitions. Feedback suggests re-adding a transition class, specifically transition-colors, to ensure smooth visual transitions during theme switches and maintain consistency with other headings.

Comment thread src/_includes/header-details.njk Outdated
@jbampton
Copy link
Copy Markdown
Member

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the styling of the 'Directory' header link in src/_includes/header-details.njk, changing the text color to a constant accent color and refining the transition property. A review comment suggests adding a specific transition duration to ensure the header's color transition is synchronized with the rest of the page during theme switches.

Comment thread src/_includes/header-details.njk Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbampton jbampton merged commit 8bd9173 into main May 2, 2026
15 of 16 checks passed
@jbampton jbampton deleted the copilot/fix-directory-header-color branch May 2, 2026 11:41
@github-project-automation github-project-automation Bot moved this from In progress to Done in Next May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants