Skip to content

Fix location overlap on index page user locations#463

Merged
jbampton merged 5 commits intoNextCommunity:mainfrom
jbampton:fix-index-location-overlap
May 2, 2026
Merged

Fix location overlap on index page user locations#463
jbampton merged 5 commits intoNextCommunity:mainfrom
jbampton:fix-index-location-overlap

Conversation

@jbampton
Copy link
Copy Markdown
Member

@jbampton jbampton commented May 2, 2026

Screenshot 2026-05-03 at 2 35 00 am

@jbampton jbampton requested a review from BaseMax as a code owner May 2, 2026 16:49
@jbampton jbampton self-assigned this May 2, 2026
@jbampton jbampton added this to Next May 2, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Next May 2, 2026
@jbampton jbampton added the good first issue Good for newcomers label May 2, 2026
@jbampton jbampton added this to the Turbo milestone May 2, 2026
@jbampton jbampton requested a review from Copilot May 2, 2026 16:50
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the location display in src/index.njk to use a line break instead of a comma when both location and country are provided. The review feedback highlights that the multi-line formatting in the template will introduce unwanted whitespace in the UI and that the
tag may cause the styled to appear broken; it is recommended to use a block-level display class and keep the template logic on a single line to maintain visual integrity.

Comment thread src/index.njk Outdated
@jbampton
Copy link
Copy Markdown
Member Author

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the index page’s user-card header rendering to prevent long “location, country” strings from overlapping or crowding other header content by stacking the two values.

Changes:

  • Render location and country on separate lines (only inserting a line break when both are present).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the location display in src/index.njk to use a line break instead of a comma when both a location and country are present. Feedback indicates that the multi-line formatting in the template introduces unwanted whitespace in the rendered HTML, which may cause alignment issues within the UI component.

Comment thread src/index.njk Outdated
@jbampton jbampton requested a review from Copilot May 2, 2026 16:54
@jbampton
Copy link
Copy Markdown
Member Author

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the location and country display in src/index.njk to stack them vertically. The review feedback highlights that the current implementation using a
tag and multi-line Nunjucks syntax introduces unwanted whitespace in the rendered HTML. It is recommended to use Tailwind's flexbox utilities to stack the elements cleanly and maintain proper alignment.

Comment thread src/index.njk Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbampton
Copy link
Copy Markdown
Member Author

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the layout for displaying location and country information in src/index.njk, switching from a single-line comma-separated format to a stacked vertical layout using Flexbox. Feedback suggests improving the legibility of the stacked text by adding a vertical gap and using a semantically correct div instead of a span for the multi-line container.

Comment thread src/index.njk Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/index.njk
@jbampton
Copy link
Copy Markdown
Member Author

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the location badge in src/index.njk to use a vertical flexbox layout, separating the location and country into distinct lines. The reviewer suggests using items-end instead of items-center to ensure the text aligns correctly with the right-hand positioning of the badge.

Comment thread src/index.njk Outdated
@jbampton jbampton requested a review from Copilot May 2, 2026 17:12
@jbampton
Copy link
Copy Markdown
Member Author

jbampton commented May 2, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the location and country display in src/index.njk by replacing the single-line comma-separated format with a vertical flex layout. A review comment suggests adding the text-right utility class to the container to ensure that text remains right-aligned if the location or country names are long enough to wrap onto multiple lines.

Comment thread src/index.njk
<span class="shrink-0 text-[10px] bg-[var(--bg-footer)] text-[var(--text-muted)] px-2 py-1 rounded font-bold uppercase border border-[var(--border-color)]">
{{ location }}{% if location and country %}, {% endif %}{{ country }}
</span>
<div class="flex flex-col items-end gap-0.5 shrink-0 text-[10px] bg-[var(--bg-footer)] text-[var(--text-muted)] px-2 py-1 rounded font-bold uppercase border border-[var(--border-color)]">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure visual consistency when location or country names are long enough to wrap, consider adding the text-right utility class. While items-end aligns the spans themselves to the right of the flex container, text-right ensures that the text content within those spans remains right-aligned if it breaks into multiple lines.

            <div class="flex flex-col items-end text-right gap-0.5 shrink-0 text-[10px] bg-[var(--bg-footer)] text-[var(--text-muted)] px-2 py-1 rounded font-bold uppercase border border-[var(--border-color)]">

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/index.njk
@jbampton jbampton merged commit 072ee5b into NextCommunity:main May 2, 2026
16 of 17 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Next May 2, 2026
@jbampton jbampton deleted the fix-index-location-overlap branch May 2, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants