Fix #468#475
Conversation
Add min-w, max-w, and shrink-0 to the location/country metadata container to avoid it collapsing when name or role text is long. Addresses review feedback from PR NextCommunity#466.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new user profile for Saish Milind Wadnere and updates the layout in src/index.njk to include width constraints and prevent shrinking on the location container. Feedback was provided to replace the arbitrary rem-based width values with standard Tailwind CSS spacing classes to maintain consistency with the framework's conventions.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a new user profile for Saish Milind Wadnere and updates the styling of the location and country badge in the index template. The review feedback suggests removing the hardcoded minimum and maximum width constraints on the badge to allow it to size naturally based on the content length, while keeping the shrink-0 property to prevent layout compression.
There was a problem hiding this comment.
Pull request overview
This PR addresses a UI regression in the developer directory card header where the location/country badge can collapse when the name/role text is long, and it also adds a new developer profile entry.
Changes:
- Adds width-related Tailwind utility classes to the location/country metadata container in
src/index.njkto prevent badge collapse. - Adds a new user profile YAML file under
src/users/.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index.njk | Adjusts the location/country badge flex behavior via additional Tailwind classes to maintain layout under long text. |
| src/users/saishwadnere.yaml | Adds a new developer profile for inclusion in the directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
github-project-automation
Bot
moved this from Review in progress
to Reviewer approved
in Next
Changes
min-w-28,max-w-40, andshrink-0to the location/country metadata container insrc/index.njkto prevent it from collapsing when name or role text is longContext
The removal of
shrink-0in PR #466 caused the metadata badge to squeeze to its minimum width whenever the name or role text was long, leading to an awkward vertical stack of single words. This fix adds width constraints to maintain a balanced layout.