Skip to content

fix: Test and tweak pkg install #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phuongfi91 merged 3 commits into from
May 11, 2026
Merged

fix: Test and tweak pkg install #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52a58df
feat: add gpg to container
phuongfi91 May 11, 2026
5cd67c7
fix: Test and tweak pkg install
phuongfi91 May 11, 2026
6967e7d
Merge branch 'latest' into feat/phuongfi91/gpg
phuongfi91 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
openssh-client \
jq \
zsh \
gpg \
gpg-agent \
gnupg \
# Database clients:
postgresql-client \
libmariadb-dev \
Expand Down
2 changes: 1 addition & 1 deletion tests/specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ commandTests:
- name: "gpg is installed in path"
command: "gpg"
args: ["--version"]
expectedOutput: ["gpg (GnuPG)"]
expectedOutput: ["gpg"]
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The expected output for the gpg command has been simplified from gpg (GnuPG) to just gpg. This reduces the specificity of the test, as gpg is a very common string and might lead to false positives (e.g., if the command fails but the error message contains the word 'gpg'). It is recommended to keep the more specific string to ensure the correct GnuPG implementation is present and working as expected.

    expectedOutput: ["gpg (GnuPG)"]


- name: "uv is installed in path"
command: "uv"
Expand Down
Loading