Skip to content

chore(deps): remove tornado dependency and clean up references#665

Merged
LaikaN57 merged 1 commit intomainfrom
remove-tornado/10-remove-dep
Feb 26, 2026
Merged

chore(deps): remove tornado dependency and clean up references#665
LaikaN57 merged 1 commit intomainfrom
remove-tornado/10-remove-dep

Conversation

@LaikaN57
Copy link
Member

Summary

Final PR in the tornado removal migration. Remove the tornado==6.5.4 dependency and clean up remaining references.

What changed

  • pyproject.toml: Removed tornado==6.5.4 and its comments from [project] dependencies
  • uv.lock: Regenerated without tornado (confirmed: Removed tornado v6.5.4)
  • README.rst: Changed "Kingpin leverages python's tornado engine" to "Kingpin leverages python's asyncio library"
  • actors/group.py: Removed stale comment referencing "tornado-ism"

What was NOT changed (intentional)

  • mock_tornado() and tornado_value() in actors/test/helper.py — pure-Python helpers with no tornado imports. Renaming would touch ~100 call sites for zero behavioral benefit (documented in retro.md).

Migration summary (PRs 1-10)

Metric Value
PRs merged 10
Files changed ~25
Runtime deps removed 1 (tornado==6.5.4)
Runtime deps added 0
Tests before 361
Tests after 360 (1 deleted: tested tornado-specific return type)

Why this is safe

  • All tornado imports were removed in PRs 1-9 — this PR only removes the dependency declaration
  • If any code still imported tornado, make test would fail with ModuleNotFoundError
  • kingpin --help verified working without tornado installed

Test plan

  • make test passes (360 tests, 0 failures)
  • kingpin --help works without tornado
  • grep -rn "tornado" kingpin/ --include="*.py" returns zero results (excluding helper function names)
  • ruff check clean

Part 10 of 10 — tornado removal complete! 🎉

🤖 Generated with Claude Code

Remove tornado==6.5.4 from pyproject.toml dependencies and regenerate
uv.lock. Update README.rst to reference asyncio instead of tornado.
Remove stale tornado comment in group.py. Zero new runtime dependencies
added throughout this migration — all replacements use Python stdlib.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@LaikaN57 LaikaN57 marked this pull request as ready for review February 26, 2026 20:47
@LaikaN57 LaikaN57 merged commit d693987 into main Feb 26, 2026
4 of 5 checks passed
@LaikaN57 LaikaN57 deleted the remove-tornado/10-remove-dep branch February 26, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant