chore(deps): remove tornado dependency and clean up references#665
Merged
chore(deps): remove tornado dependency and clean up references#665
Conversation
Remove tornado==6.5.4 from pyproject.toml dependencies and regenerate uv.lock. Update README.rst to reference asyncio instead of tornado. Remove stale tornado comment in group.py. Zero new runtime dependencies added throughout this migration — all replacements use Python stdlib. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final PR in the tornado removal migration. Remove the
tornado==6.5.4dependency and clean up remaining references.What changed
pyproject.toml: Removedtornado==6.5.4and its comments from[project] dependenciesuv.lock: Regenerated without tornado (confirmed:Removed tornado v6.5.4)README.rst: Changed "Kingpin leverages python's tornado engine" to "Kingpin leverages python's asyncio library"actors/group.py: Removed stale comment referencing "tornado-ism"What was NOT changed (intentional)
mock_tornado()andtornado_value()inactors/test/helper.py— pure-Python helpers with no tornado imports. Renaming would touch ~100 call sites for zero behavioral benefit (documented in retro.md).Migration summary (PRs 1-10)
tornado==6.5.4)Why this is safe
make testwould fail withModuleNotFoundErrorkingpin --helpverified working without tornado installedTest plan
make testpasses (360 tests, 0 failures)kingpin --helpworks without tornadogrep -rn "tornado" kingpin/ --include="*.py"returns zero results (excluding helper function names)ruff checkcleanPart 10 of 10 — tornado removal complete! 🎉
🤖 Generated with Claude Code