Chore/#147 QRCodeResponse 팝업 뷰 UI 수정 및 response 수정#151
Merged
longlivedrgn merged 3 commits intodevelopfrom Feb 27, 2024
Merged
Conversation
wngus4296
approved these changes
Feb 26, 2024
Collaborator
wngus4296
left a comment
wngus4296
left a comment
There was a problem hiding this comment.
용재 깔끔하게 코드 잘 짠 거 같당!! qr 타입이 많아서 테스트 힘들었을 텐데 고생했어!! 🫡🫡
| stackView.axis = .vertical | ||
| stackView.alignment = .center | ||
| stackView.addArrangedSubviews([self.emptyMainTitle, self.emptySubTitle]) | ||
| stackView.isHidden = true |
|
|
||
| private func configureConstraints() { | ||
| self.snp.makeConstraints { make in | ||
| make.width.equalTo(335) |
Collaborator
There was a problem hiding this comment.
이거 horizontalEdge로 설정 안해줘두 되나?! 고정길이인지 디자인분들께 물어봐야겠당
Collaborator
Author
There was a problem hiding this comment.
요거 edge해줘야될 거 같아!! 바로 수정할게에🏃🏻♂️
Comment on lines
+12
to
+16
| private let iconImageView: UIImageView = { | ||
| let imageView = UIImageView() | ||
|
|
||
| return imageView | ||
| }() |
Collaborator
There was a problem hiding this comment.
완전 마이너한 의견 .. 요고 안에 들어갈 거 없으면 아래처럼 써도 될 듯!!
Suggested change
| private let iconImageView: UIImageView = { | |
| let imageView = UIImageView() | |
| return imageView | |
| }() | |
| private let iconImageView = UIImageView() |
Collaborator
Author
There was a problem hiding this comment.
완전 메이저한 의견... 바로 수정할게!!!
Comment on lines
+100
to
+102
| guard let error = error as? MoyaError else { return } | ||
| guard let statusCode = error.response?.statusCode else { return } | ||
| guard let errorResponse = QRCodeValidationResponse(statusCode: statusCode) else { return } |
- 불필요한 코드 삭제 - Constraint 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업한 내용
(오늘 12시 이후에 실제 공연 입장이 제대로 찍히는 한번 더 확인할 예정이에요!)
스크린샷
관련 이슈