Skip to content

Feat/#94: 이미지 뷰어 좌우 이동 화살표 버튼 추가 및 FullScreen Dialog 전환#96

Merged
DongChyeon merged 3 commits into
developfrom
feat/#94-image-viewer-navigation-buttons
Apr 26, 2026
Merged

Feat/#94: 이미지 뷰어 좌우 이동 화살표 버튼 추가 및 FullScreen Dialog 전환#96
DongChyeon merged 3 commits into
developfrom
feat/#94-image-viewer-navigation-buttons

Conversation

@DongChyeon
Copy link
Copy Markdown
Member

@DongChyeon DongChyeon commented Apr 26, 2026

🛠 Related issue

closed #94

어떤 변경사항이 있었나요?

  • 🐞 BugFix Something isn't working
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (Junit, etc.)

✅ CheckPoint

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • PR 컨벤션에 맞게 작성했습니다. (필수)
  • merge할 브랜치의 위치를 확인해 주세요(main❌/develop⭕) (필수)
  • Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다. (필수)
  • BugFix의 경우, 버그의 원인을 파악하였습니다. (선택)

✏️ Work Description

image - `ImageViewerScreen`에 스와이프 대신 좌우 화살표 버튼 추가 - 첫 번째 페이지에서 왼쪽 버튼 숨김, 마지막 페이지에서 오른쪽 버튼 숨김 - 단일 이미지일 경우 양쪽 버튼 모두 숨김 - 버튼: 검정 40% 투명도 CircleShape 30dp, 아이콘 14dp (gray0 tint) - `ImageViewerScreen`을 Navigation Compose `dialog`로 전환 - HomeScreen 탭 선택 상태(투표 피드 / 내 투표)가 ImageViewer 복귀 시 초기화되는 문제 해결 - `DialogProperties(usePlatformDefaultWidth = false, decorFitsSystemWindows = false, dismissOnClickOutside = false)` 적용 - `statusBarsPadding` / `navigationBarsPadding` 적용

😅 Uncompleted Tasks

  • N/A

📢 To Reviewers

  • Dialog 전환으로 HomeRoute가 composition에서 제거되지 않아 LaunchedEffect(initialTab) 재실행 없이 탭 상태가 보존됩니다.
  • decorFitsSystemWindows = false로 검은 배경이 상태바까지 확장되며, statusBarsPadding / navigationBarsPadding으로 콘텐츠 영역을 안전 영역 안으로 밀어 넣었습니다.

📃 RCA 룰

  • R: 꼭 반영해 주세요. 적극적으로 고려해 주세요. (Request changes)
  • C: 웬만하면 반영해 주세요. (Comment)
  • A: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다. (Approve)

DongChyeon and others added 3 commits April 26, 2026 14:32
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

Warning

Rate limit exceeded

@DongChyeon has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 33 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 15 minutes and 33 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: bb14d552-7316-4970-88e0-223648529702

📥 Commits

Reviewing files that changed from the base of the PR and between 4acdf78 and be5c786.

📒 Files selected for processing (2)
  • core/ui/src/main/java/com/sseotdabwa/buyornot/core/ui/imageviewer/ImageViewerNavigation.kt
  • core/ui/src/main/java/com/sseotdabwa/buyornot/core/ui/imageviewer/ImageViewerScreen.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/#94-image-viewer-navigation-buttons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DongChyeon DongChyeon changed the title feat/#94: 이미지 뷰어 좌우 이동 화살표 버튼 추가 및 FullScreen Dialog 전환 Feat/#94: 이미지 뷰어 좌우 이동 화살표 버튼 추가 및 FullScreen Dialog 전환 Apr 26, 2026
@DongChyeon DongChyeon requested a review from Imagine-Choi April 26, 2026 05:58
@DongChyeon DongChyeon added ✨ FEAT 기능 개발 (애매하면 기능 개발로 두도록 하자) 💪 동현동현동현 labels Apr 26, 2026
@DongChyeon DongChyeon self-assigned this Apr 26, 2026
@DongChyeon DongChyeon merged commit 4573bfb into develop Apr 26, 2026
2 checks passed
@DongChyeon DongChyeon deleted the feat/#94-image-viewer-navigation-buttons branch April 26, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ FEAT 기능 개발 (애매하면 기능 개발로 두도록 하자) 💪 동현동현동현

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Feature - 이미지 상세보기 다중 사진 이동 버튼 추가

1 participant