centralize GraphQL error handling in nexus_integration#23101
Merged
Conversation
Adds handleGraphError<T> in nexus_integration/util.ts that reuses graphErrorContext to extract the error code and diagnostic context, logs that context before surfacing the notification, and returns the caller's fallback. Skip-codes, no-report-codes, allowReport, and notification id are configurable. Migrates the simple / skip-on-code catches: onGetMyCollections, onGetNexusCollections, onResolveCollectionUrl, onGetModFiles, onModFileContents, onGetModInfo, onGetPreferences. Endpoints with bespoke per-code branching are left as-is. Also fixes nexusGetCollections in INexusAPIExtension.ts, which declared PromiseLike<ICollection[]> but actually returned Partial<ICollection>[] | undefined. fixes https://linear.app/nexus-mods/issue/APP-443 fixes #23077
erri120
approved these changes
May 11, 2026
pull Bot
pushed a commit
to A-Archives-and-Forks/Vortex
that referenced
this pull request
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds handleGraphError in nexus_integration/util.ts that reuses graphErrorContext to extract the error code and diagnostic context, logs that context before surfacing the notification, and returns the caller's fallback. Skip-codes, no-report-codes, allowReport, and notification id are configurable.
Migrates the simple / skip-on-code catches: onGetMyCollections, onGetNexusCollections, onResolveCollectionUrl, onGetModFiles, onModFileContents, onGetModInfo, onGetPreferences. Endpoints with bespoke per-code branching are left as-is.
Also fixes nexusGetCollections in INexusAPIExtension.ts, which declared PromiseLike<ICollection[]> but actually returned Partial[] | undefined.
fixes https://linear.app/nexus-mods/issue/APP-443
fixes #23077