fix v2.0 elevation chain failing "Deployment interrupted"#23107
Merged
Conversation
Three independent issues each broke elevated symlink deployment in v2.0: 1. main.ts ran telemetry/IPC/Sass init before the --run branch, eating the renderer's monitorConsent watchdog on UAC-elevated cold starts. The --run handler is now the first thing main() does after argv parsing. 2. node_modules/json-socket was no longer in electron-builder's asarUnpack, so it wasn't available as a real file to the elevated Node child. 3. runElevated()'s moduleRoot used standard Node paths only. With ELECTRON_RUN_AS_NODE=1 the elevated child has no asar redirect, so even with json-socket unpacked it wouldn't be found at the asar.unpacked location. Prepending <resourcesPath>/app.asar.unpacked/node_modules to moduleRoot solves this in production; the path is harmless in dev. The failure mode was invisible: elevatedMain's handleError only wrote to console.error, lost in the detached elevated process. Replaced with a logError helper that appends to vortex.log via ELECTRON_USERDATA. Added [elevation-trace] entries on the renderer and in main.ts so the next failure produces a single grep-able fingerprint; [ELEVATED] is reserved for errors, success is proven by [MAIN] traces + [RENDERER] initialised received.
makeNXMLinkCallback(api) was wrapped in `void`, which discards the returned callback function. As a result api.registerProtocol was called with `undefined` as the handler, so opening nxm:// links did nothing. Introduced in d443c0e (fix NXM handler notification firing on every startup) when the call site was wrapped to suppress the unused-return warning.
Aragas
approved these changes
May 11, 2026
pull Bot
pushed a commit
to A-Archives-and-Forks/Vortex
that referenced
this pull request
May 11, 2026
This was
linked to
issues
May 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--runmoved to top ofmain()so it runs before the renderer's watchdog expires, (2)node_modules/json-socketre-added toasarUnpack, (3)<resourcesPath>/app.asar.unpacked/node_modulesprepended to the elevated tmp script'smoduleRootsinceELECTRON_RUN_AS_NODEdisables Electron's asar redirect.console.errorinelevatedMain(lost in detached elevated process) with alogErrorhelper that writes tovortex.log. Adds[elevation-trace]entries so future failures have a grep-able fingerprint.undefineddue to a strayvoidoperator (regression from d443c0e).fixes APP-444
fixes #23043
fixes #23073