persist verifier repairs via subtree-aware kv delete#23112
Merged
Conversation
Repair removed bad entries from memory but the delete never reached DuckDB: computeStateDiff emitted only leaf removes and bulkRemoveItem matched keys exactly, so blob rows at intermediate paths (state values whose prototype is not Object.prototype - Date, Error, etc.) survived and re-hydrated next launch. Infinite repair loop. removeItem and bulkRemoveItem now subtree-delete via "WHERE key = $1 OR starts_with(key, $2)". computeStateDiff also emits a container-path remove on object subtree removal; leaf removes stay as fallback. starts_with (not LIKE) so segments like skyrim_se can't over-match. Original report and partial fix in PR #23100 by Alex Tabisz; that fix patched removeItem, but the production path goes through bulkRemoveItem. Co-Authored-By: Alex Tabisz <alex@tabisz.org> fixes APP-446
Aragas
approved these changes
May 11, 2026
pull Bot
pushed a commit
to A-Archives-and-Forks/Vortex
that referenced
this pull request
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repair removed bad entries from memory but the delete never reached DuckDB: computeStateDiff emitted only leaf removes and bulkRemoveItem matched keys exactly, so blob rows at intermediate paths (state values whose prototype is not Object.prototype - Date, Error, etc.) survived and re-hydrated next launch. Infinite repair loop.
removeItem and bulkRemoveItem now subtree-delete via "WHERE key = $1 OR starts_with(key, $2)". computeStateDiff also emits a container-path remove on object subtree removal; leaf removes stay as fallback. starts_with (not LIKE) so segments like skyrim_se can't over-match.
Original report and partial fix in PR #23100 by Alex Tabisz; that fix patched removeItem, but the production path goes through bulkRemoveItem.
Co-Authored-By: Alex Tabisz alex@tabisz.org @atabisz
fixes APP-446