Force SSL missing when using Custom locations

[crawc]

Checklist

• Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
  YES, pulled today.

• Are you sure you're not using someone else's docker image?
  Yes, jc21/nginx-proxy-manager:latest

• If having problems with Lets Encrypt, have you made absolutely sure your site is accessible from outside of your network? Not useing Lets Encrypt, but using custom SSL certs.

Describe the bug

• A clear and concise description of what the bug is.
  After adding a Proxy host using a custom SSL cert (I don't think this matters, but might) with the Force SSL option enabled the site redirects a expected, but when I add a Custom location, with Force SSL still enabled the redirection for HTTP to HTTPS no longer works or these lines are removed.

# Force SSL
include conf.d/include/force-ssl.conf;

These line can be be added back using the Advanced tab as a workaround. It seems the Force SSL is skipped when a Custom location is being used.

• What version of Nginx Proxy Manager is reported on the login page?
  v2.0.14

To Reproduce
Steps to reproduce the behavior:

1. Add a new Proxy host with Force SSL enabled.
2. Check the generated config file to confirm it has the force SSL lines. data/nginx/proxy_host/1.conf
3. Add a Custom location.
4. Check the generated config file to confirm it has the force SSL lines are now missing.

Expected behavior
To continue to include the force-ssl.conf file when a custom location is added.

[Kenchava]

i just encountered this issue on v2.3.1, I bypassed it by adding the include conf.d/include/force-ssl.conf; line to the custom configuration of each location, but still kind of annoying...

[Anunayj]

Is there any reason as to why http-> https rewrite for forced SSL should be in the location / block and not part of the global server block? (same for HSTS)
https://github.com/jc21/nginx-proxy-manager/blob/301499dc525d39f226b391fb88f28385ce0cb008/backend/templates/proxy_host.conf#L46
Right now it does not work with custom locations because using another location / block would prioritize it over the first one.

[Anunayj]

To add to that, there seem to be redundant HSTS entries
https://github.com/jc21/nginx-proxy-manager/blob/301499dc525d39f226b391fb88f28385ce0cb008/backend/templates/proxy_host.conf#L47
https://github.com/jc21/nginx-proxy-manager/blob/301499dc525d39f226b391fb88f28385ce0cb008/backend/templates/proxy_host.conf#L13

[chaptergy]

@Anunayj see #68 (comment) for his explanation

[henkisdabro]

I'm still having troubles with this. Statically hosted files served via NPM render continous 301 redirects unless I disable the checkbox for Force SSL. Even adding in the include line and manually adding the if statement into the custom box, I can't get this to work.

[github-actions]

Issue is now considered stale. If you want to keep it open, please comment 👍

[github-actions]

Issue was closed due to inactivity.