Skip to content

Check also certificate keys using elliptic curve algorithms#665

Closed
mkochenough wants to merge 3 commits intoNginxProxyManager:developfrom
mkochenough:elliptic-curves
Closed

Check also certificate keys using elliptic curve algorithms#665
mkochenough wants to merge 3 commits intoNginxProxyManager:developfrom
mkochenough:elliptic-curves

Conversation

@mkochenough
Copy link
Copy Markdown

This should help with issue #663.

@jc21
Copy link
Copy Markdown
Member

jc21 commented Oct 17, 2020

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-665

@mkochenough
Copy link
Copy Markdown
Author

Thanks for this hint. I used this docker image. It still fails to import the key. Unfortunately the error message is empty. I will dig a bit around to fix this.

@MarceloLagos
Copy link
Copy Markdown
Contributor

MarceloLagos commented Oct 18, 2020

The error message is empty because it doesn't fail the openssl command. Instead the openssl command is successful, but the output is empty, therefore it fails later in the check to see if "key ok" is in the result.
Furthermore even if that doesn't fail, the check for "key ok" will fail, since the verification for EC keys doesn't return "key ok" anywhere. It's a different (2 lines) message than the successful check for RSA keys. See my post on #663

@jc21 jc21 changed the base branch from master to develop October 18, 2020 07:52
@jc21
Copy link
Copy Markdown
Member

jc21 commented Oct 18, 2020

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants