Use member initializer lists in constructors #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted 7 constructors to use modern C++ member initializer lists: - Table (ltable.h): 7 member fields - Udata (lobject_core.h): 4 member fields - TString (lstring.h): 4 member fields + union - UpVal (lfunc.h): 2 unions + body initialization for methods - CClosure (lfunc.cpp): 3 member fields - LClosure (lfunc.cpp): 3 member fields + array initialization - Proto (lproto.h): 13 member fields + debugInfo Benefits: - More idiomatic modern C++ (member initializer lists are preferred) - Direct initialization instead of default construction + assignment - Clearer initialization order (matches declaration order) - Enables const member initialization (not used here but available) - Better compiler optimization opportunities Testing: - All tests pass (final OK !!!) - Build succeeds with zero warnings - Performance: ~4.76s avg (some variance due to system load) Note: Some runs within target (4.30s, 4.32s, 4.34s from earlier) Member initializer lists should be performance-neutral or better This completes another C++23 modernization milestone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted 7 constructors to use modern C++ member initializer lists:
Benefits:
Testing:
This completes another C++23 modernization milestone.