feat: controller http api options and images

assets/locales/cs/genericComponents.json

@@ -103,7 +103,6 @@
   "InitialSyncInProgress": "Probíhá počáteční synchronizace...",
   "NodeSettings": "Nastavení Uzlu...",
   "RemoveNode": "Odstranit Uzel...",
-  "RemovingNode": "Odstraňování Uzlu...",
   "ErrorOccurred": "Došlo k chybě",
   "DataLocation": "Umístění dat",
   "AvailableDiskSpace": "{{space}}GB dostupného místa na disku",

assets/locales/cs/translation.json

@@ -6,6 +6,7 @@
   "AddNode": "Přidat Uzel",
   "StopeNodeToChangeSettings": "Uzel musí být zastaven pro provedení změn",
   "RemoveNode": "Odstranit uzel",
+  "RemovingNode": "Odstraňování Uzlu...",
   "RemoveThisNode": "Odstranit tento uzel",
   "Install Docker": "Nainstalovat Docker",
   "Type": "Typ",

assets/locales/en/genericComponents.json

@@ -109,7 +109,6 @@
   "InitialSyncInProgress": "Initial sync in progress...",
   "NodeSettings": "Node Settings...",
   "RemoveNode": "Remove Node...",
-  "RemovingNode": "Removing node...",
   "ErrorOccurred": "Error occurred",
   "DataLocation": "Data location",
   "AvailableDiskSpace": "{{space}}GB available disk space",

assets/locales/en/translation.json

@@ -6,6 +6,7 @@
   "AddNode": "Add Node",
   "StopeNodeToChangeSettings": "The node must be stopped to make changes",
   "RemoveNode": "Remove node",
+  "RemovingNode": "Removing node...",
   "RemoveThisNode": "Remove this node",
   "Install Docker": "Install Docker",
   "Type": "Type",

src/common/NodeSpecs/base/base-v1.0.0.json

@@ -107,7 +107,7 @@
       "documentation": "https://docs.base.org/network-information/"
     }
   },
-  "iconUrl": "https://ethereum.png",
+  "iconUrl": "https://pub-9f2dc808c3d748eabde036c3d3465ee6.r2.dev/base.png",
   "addNodeDescription": "Decentralization and collaboration are critical for the longer-term success of Base and scaling Ethereum. That’s why we are working with OP Labs and the Optimism Collective on a plan to scale Ethereum in a decentralized way.",
   "description": "Base is a secure, low-cost, developer-friendly Ethereum L2 built to bring the next billion users onchain. It's built on Optimism’s open-source OP Stack.",
   "documentation": {

src/common/NodeSpecs/besu/besu-v1.0.0.json

@@ -419,7 +419,7 @@
     "docker": "https://besu.hyperledger.org/en/stable/HowTo/Get-Started/Installation-Options/Run-Docker-Image/",
     "releaseNotesUrl": "https://github.com/hyperledger/besu/releases"
   },
-  "iconUrl": "https://clientdiversity.org/assets/img/execution-clients/besu-text-logo.png",
+  "iconUrl": "https://pub-9f2dc808c3d748eabde036c3d3465ee6.r2.dev/besu.png",
   "resources": [
     {
       "label": "Twitter",

src/main/menu.ts

@@ -1,3 +1,4 @@
+import path from 'node:path';
 import {
   type BrowserWindow,
   Menu,
@@ -10,7 +11,6 @@ import {
   getSetHasSeenAlphaModal,
   getSetHasSeenSplashscreen,
 } from './state/settings';
-import path from 'node:path';
 
 import { runBenchmark } from './benchbuddy/runBenchmark';
 import { getDebugInfoString, getGithubIssueProblemURL } from './debug';

src/main/nodeLibraryManager.ts

@@ -57,6 +57,7 @@ let controllerApiURL = 'https://api.nicenode.xyz/api';
 let isControllerApiHttp = false;
 if (process.env.CONTROLLER_API_URL) {
   controllerApiURL = process.env.CONTROLLER_API_URL;
+  console.log('controllerApiURL: ', controllerApiURL);
 }
 if (
   process.env.CONTROLLER_API_URL_IS_HTTP ||

src/renderer/Generics/redesign/ClientCard/ClientCard.tsx

@@ -26,8 +26,16 @@ import {
  * Primary UI component for user interaction
  */
 export const ClientCard = (props: ClientProps) => {
-  const { displayName, packageName, status, name, nodeType, onClick, stats } =
-    props;
+  const {
+    displayName,
+    packageName,
+    status,
+    name,
+    nodeType,
+    onClick,
+    stats,
+    iconUrl,
+  } = props;
 
   const { t: g } = useTranslation('genericComponents');
 
@@ -163,7 +171,11 @@ export const ClientCard = (props: ClientProps) => {
         <div className={[clientBackground, `${stoppedStyle}`].join(' ')}>
           <div className={clientDetails}>
             <div className={clientIcon}>
-              <NodeIcon iconId={name.replace('-beacon', '')} size="medium" />
+              <NodeIcon
+                iconId={name.replace('-beacon', '')}
+                size="medium"
+                iconUrl={iconUrl}
+              />
             </div>
             <div className={clientTitle}>{displayName}</div>
           </div>

src/renderer/Generics/redesign/Header/Header.tsx

@@ -38,6 +38,7 @@ export const Header = ({ nodeOverview, isPodmanRunning }: HeaderProps) => {
     name,
     displayName,
     title,
+    iconUrl,
     info,
     screenType,
     status,
@@ -93,7 +94,7 @@ export const Header = ({ nodeOverview, isPodmanRunning }: HeaderProps) => {
   return (
     <div className={container}>
       <div className={iconContainer}>
-        <NodeIcon iconId={name} size="large" />
+        <NodeIcon iconId={name} size="large" iconUrl={iconUrl} />
       </div>
       <div className={textContainer}>
         <div className={titleContainer}>

src/renderer/Generics/redesign/Modal/modal.css.ts

@@ -131,6 +131,7 @@ export const modalChildrenContainer = style({
     '&.addNode': {
       overflowY: 'auto',
       overflowX: 'hidden',
+      scrollbarGutter: 'stable', // reserves space for scrollbar
     },
     '&.nodeSettings': {
       padding: 0,

src/renderer/Generics/redesign/NodeIcon/NodeIcon.tsx

@@ -98,10 +98,8 @@ const NodeIcon = ({ iconId, status, size, iconUrl }: NodeIconProps) => {
       >
         <img
           src={
-            NODE_ICONS[iconId as NodeIconId] ||
-            iconUrl ||
-            'https://raw.githubusercontent.com/home-assistant/home-assistant.io/current/source/images/favicon-192x192.png' ||
-            undefined
+            // Just iconUrl isn't backwards compatible, but will be used now
+            NODE_ICONS[iconId as NodeIconId] || iconUrl || undefined
           }
           alt={g('NodeIcon')}
           className={imageStyle}

src/renderer/Generics/redesign/SelectCard/SelectCard.tsx

@@ -23,7 +23,11 @@ export interface SelectCardProps {
    */
   info?: string;
   /**
-   * Which icon?
+   * Icon URL
+   */
+  iconUrl?: string;
+  /**
+   * Which icon? (deprecating)
    */
   iconId: NodeIconId;
   /**
@@ -50,6 +54,7 @@ export interface SelectCardProps {
 const SelectCard = ({
   onClick,
   title,
+  iconUrl,
   info,
   iconId,
   minority = false,
@@ -93,7 +98,7 @@ const SelectCard = ({
       tabIndex={0}
     >
       <div className={containerStyles.join(' ')}>
-        <NodeIcon iconId={iconId} size="medium" />
+        <NodeIcon iconId={iconId} size="medium" iconUrl={iconUrl} />
         <div className={textContainer}>
           {/* TODO: Fix height to 60px */}
           <div className={titleStyle}>{title}</div>

src/renderer/Generics/redesign/SidebarNodeItem/SidebarNodeItem.tsx

@@ -47,6 +47,7 @@ export interface SidebarNodeItemProps {
 export const SidebarNodeItem = ({
   onClick,
   title,
+  iconUrl,
   info,
   iconId,
   status,
@@ -78,7 +79,12 @@ export const SidebarNodeItem = ({
       tabIndex={0}
     >
       <div className={iconContainer}>
-        <NodeIcon iconId={iconId} status={status} size="small" />
+        <NodeIcon
+          iconId={iconId}
+          status={status}
+          size="small"
+          iconUrl={iconUrl}
+        />
       </div>
       <div className={textContainer}>
         <div className={titleStyle}>{title}</div>

src/renderer/Generics/redesign/consts.ts

@@ -35,6 +35,7 @@ export interface ClientProps {
   packageName: string;
   displayName: string;
   name: NodeBackgroundId | string;
+  iconUrl?: string;
   version: string;
   nodeType: string;
   status: ClientStatusProps;