Add tests for voice provider configuration helpers#6
Merged
NichUK merged 1 commit intofeature/voice-modefrom Apr 4, 2026
Merged
Add tests for voice provider configuration helpers#6NichUK merged 1 commit intofeature/voice-modefrom
NichUK merged 1 commit intofeature/voice-modefrom
Conversation
Cover the pure shared logic in VoiceProviderConfigurationStoreExtensions with focused unit tests for case-insensitive provider lookup, case-insensitive setting lookup, SetValue creation/update behavior, and removal of blank or null values.
There was a problem hiding this comment.
Pull request overview
Adds focused unit tests in OpenClaw.Shared.Tests to validate the shared, pure-logic behavior of VoiceProviderConfigurationStoreExtensions, helping ensure consistent case-insensitive lookups and predictable set/remove semantics for provider configuration values.
Changes:
- Added unit coverage for case-insensitive provider lookup (
GetOrAddProvider,FindProvider). - Added unit coverage for case-insensitive setting lookup (
GetValueon configuration and store). - Added unit coverage for
SetValuebehaviors: trimming, updating existing entries case-insensitively, and removing entries on blank/null values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover the pure shared logic in VoiceProviderConfigurationStoreExtensions with focused unit tests for case-insensitive provider lookup, case-insensitive setting lookup, SetValue creation/update behavior, and removal of blank or null values.