Review offers by Nicklason · Pull Request #361 · Nicklason/tf2-automatic

Nicklason · 2020-03-04T19:58:57Z

Resolves: #174

If review is enabled then the bot won't decline - invalid items - overstocked - invalid value

idinium96 · 2020-03-05T12:55:10Z

I've tried it, so far so good.
Suggestions:

Send notification to the trade partner that his/her trade is pending for review by the owner so that he/she knows that they need to wait.
It might be nice if GIFT also can be reviewed.
Send notification to ADMINS if there is any trade that needs to be reviewed? maybe like every # hours?

review1
review2

Thanks.

Nicklason · 2020-03-05T13:01:14Z

I've tried it, so far so good.
Suggestions:

Send notification to the trade partner that his/her trade is pending for review by the owner so that he/she knows that they need to wait.

It might be nice if GIFT also can be reviewed.

Send notification to ADMINS if there is any trade that needs to be reviewed? maybe like every # hours?

review1
review2

Thanks.

Already made an issue for notifying #362

Nicklason · 2020-03-05T13:05:15Z

Gifts won't be reviewed because it has a setting for accepting gifts. But I did make review for escrow offers because you might want to accept them anyway.

idinium96 · 2020-03-05T13:15:39Z

Already made an issue for notifying #362

Yeah, it should be implemented (for me... need to wait for others review).

Gifts won't be reviewed because it has a setting for accepting gifts. But I did make review for escrow offers because you might want to accept them anyway.

I see... then "ALLOW_ESCROW" in .env and ecosystem.json should be set true?

Received offer alerts

idinium96 · 2020-03-06T06:49:57Z

@Nicklason, I think it's best to check for bans/escrow before skipping the trade offer for review because of OVERSTOCKED/INVALID_ITEM/INVALID_VALUE case.
escrow
escrow2

Nicklason · 2020-03-06T14:43:00Z

@Nicklason, I think it's best to check for bans/escrow before skipping the trade offer for review because of OVERSTOCKED/INVALID_ITEM/INVALID_VALUE case.
escrow
escrow2

very nice that you spotted that, maybe just have the bot check for escrow and bans when it first receives the offer, if it will be in escrow then just decline it instead of skipping it

idinium96 · 2020-03-06T15:01:41Z

Yes, agree with that, unless the user sets "ALLOW_ESCROW" is true, then it will skip to review an escrow offer.

idinium96 · 2020-03-07T16:16:16Z

I don't think this is overstocked. I've set the intent for all craft weapons to bank with max=100, and the other things (like craft hats/tools) to sell with max=10 (which perhaps if someone bought some weapon from the bot, they also give some sweets or extras and the bot will accept it.)

Is it if we set intent=sell, the bot does not want the items to be in the bot's inventory, even though the bot does not have a single one of it?

overstock
overstock2

idinium96 · 2020-03-10T02:55:01Z

very nice that you spotted that, maybe just have the bot check for escrow and bans when it first receives the offer, if it will be in escrow then just decline it instead of skipping it

Will this do it?
commit

idinium96 · 2020-03-18T14:18:47Z

will this be implemented soon to the master @Nicklason?

idinium96 · 2020-03-26T09:05:49Z

Maybe if add some feature like add parameter all=true in !accepttrade or !declinetrade command.

…to review-offers

idinium96

after 5dd49f3

idinium96 · 2020-04-10T06:10:04Z

Here I have all possible cases for multiple reasons:

The only item in pricelist is:
Battle-Worn Robot Money Furnace, with
min=0,
max=1
buy.metal=0.55
sell.metal=1

INVALID_ITEMS (our side)
Invalid-item-our-side
INVALID_ITEMS (their side - partner offers correct value + item that is not in pricelist)
Invalid-item-their-side
INVALID_VALUE (our side)
invalid-value-our-side
INVALID_VALUE (their side)
invalid-value-their-side
OVERSTOCKED (when partner offers an overstocked item with correct value)
overstocked-our-side
INVALID_ITEMS, INVALID_ITEMS (if partner want to offer and take items that are not in pricelist - both side)
invalid-item-invalid-item-both-side
INVALID_ITEMS, INVALID_VALUE (their side)
invalid-items-invalid-value-their-side
INVALID_ITEMS, INVALID_VALUE (our side)
invalid-items-invalid-value-our-side
OVERSTOCKED, INVALID_VALUE (when partner offers an overstocked item and taking an incorrect value)
overstocked-invalid-value
INVALID_ITEMS, OVERSTOCKED, INVALID_VALUE (when partner offers an overstocked item and taking an incorrect value and an item that is not in pricelist)
invalid-items-overstocked-invalid-value
INVALID_ITEMS, OVERSTOCKED, INVALID_ITEMS, INVALID_VALUE (when partner offers an overstocked item and an item that is not in pricelist and taking an incorrect value and item that is not in pricelist)
invalid-items-overstocked-invalid-items-invalid-value
INVALID_ITEMS, INVALID_ITEMS, INVALID_VALUE (this might not happen. The trade partner is offering and taking the same item with both sides having an item that is not in pricelist)
invalid-items-invalid-items-invalid-value

idinium96 · 2020-04-10T06:28:07Z

This might worth mentioning here, that item overpay is still marked as OVERSTOCKED.
I add Reinforced Robot Bomb Stabilizer with intent=sell, min=0 and max=1, and this item is still not in the bot's inventory.
item-overpay-intent-sell-marked-overstockted

It only accepts if the item is set intent=bank:
item-overpay-intent-bank-accepted

#380

Dex-Mori · 2020-04-10T18:36:20Z

Got an error when sending !trades command

Shutdown > Restart

Again got this error

* src: fix problem with detecting killstreak Fixes: #386 * src: fix problem with checking escrow Fixes: #374 * add recorded trades time from first trade made in !trades command (#382) * add recorded trades time from first trade made * bring the trade records to the top Co-authored-by: idinium96 <idinium96@users.noreply.github.com> * src: fix trades command * src: pluralize item names * Add admins to friendsToKeep (#407) * fix typo and add missing variables found in schema (#408) Co-authored-by: idinium96 <idinium96@users.noreply.github.com> * src: use getAdmins function for friendsToKeep * src: use amount that the bot can trade when pluralizing * Add option to clear pricelist (#411) * src: add all option to remove command * change confirm setting * src: fix problem checking errors when sending offer * update modules * src: fix problem with queue freezing (#412) Fixes #396 * src: add message command (#395) * src: add message command * follow eslint * check if messages are enabled for user too * check once Co-authored-by: menoob003 <44436740+menoob003@users.noreply.github.com> * change a few things about the message command * fix problem with enabling messages * rename env var * add env var to templates * i am a goof * i am a goof 2 * i am a goof 3 * i am a goof 4 * i am goof 5? * it is now very nice * Review offers (#361) * src: add command checks * src: implement trades command for manual review * src: change description for trades command * src: remove unused argument * src: add functionality for review of offers If review is enabled then the bot won't decline - invalid items - overstocked - invalid value * src: manually accept / decline offers * forgot to uncomment admin check * src: fix offer logging * src: notify about offers that are pending for review * src: fix problem with no action from onNewTradeOffer handler * src: always notify reviews to admins * src: always decline escrow * src: add metadata to offer action * add missing arguments * src: find all offer reasons * add missing join * fix problem with polldata compatibility * check for escrow before marking the offer for review * add error message to accept / decline trade commands * add missing argument * fix problem with not applying action to offer * i am a goof * always message admins when offer is pending for review Co-authored-by: idinium96 <idinium96@users.noreply.github.com> * always display offer values in metal (#415) * disable reviews by default Co-authored-by: IdiNium <47635037+idinium96@users.noreply.github.com> Co-authored-by: idinium96 <idinium96@users.noreply.github.com> Co-authored-by: Mohammad Abdullah <49647622+mabdu11ah@users.noreply.github.com> Co-authored-by: Zeckatz <44436740+Zeckatz@users.noreply.github.com> Co-authored-by: menoob003 <44436740+menoob003@users.noreply.github.com>

Nicklason added 7 commits March 4, 2020 17:53

src: add command checks

935ea5a

src: implement trades command for manual review

956640d

src: change description for trades command

b9641f5

src: remove unused argument

145f765

src: add functionality for review of offers

572f4b4

If review is enabled then the bot won't decline - invalid items - overstocked - invalid value

src: manually accept / decline offers

f066b89

forgot to uncomment admin check

e0d4e9d

Nicklason requested review from Hhanuska, HunionKnight, Kuroson, MekalBoy, ZeusJunior, danocmx, lexidor, offish and viggjona March 4, 2020 19:58

src: fix offer logging

4ee9382

Nicklason added 4 commits March 5, 2020 19:09

src: notify about offers that are pending for review

a15ee7e

src: fix problem with no action from onNewTradeOffer handler

0574583

src: always notify reviews to admins

e781e22

Merge pull request #365 from Nicklason/received-offer-alerts

93aa575

Received offer alerts

This was linked to issues Mar 6, 2020

Notify trade partner the action and reason when the offer has been handled #362

Closed

Manually review offers #174

Closed

Nicklason linked an issue Mar 9, 2020 that may be closed by this pull request

Option to allow manual check for item overpay #341

Closed

Nicklason added 3 commits April 2, 2020 00:08

src: always decline escrow

e615660

Merge branch 'review-offers' of github.com:Nicklason/tf2-automatic in…

afc7d94

…to review-offers

src: add metadata to offer action

5dd49f3

idinium96 reviewed Apr 4, 2020

View reviewed changes

Nicklason added 2 commits April 10, 2020 01:00

add missing arguments

ea8173c

src: find all offer reasons

53cdd51

add missing join

871b7b8

Nicklason added 8 commits April 12, 2020 01:45

fix problem with polldata compatibility

b58a152

check for escrow before marking the offer for review

8aac0d6

add error message to accept / decline trade commands

215c9f9

Merge branch 'development' into review-offers

d619cc7

add missing argument

7fb3a41

fix problem with not applying action to offer

e9099f0

i am a goof

f42e6fa

always message admins when offer is pending for review

dc4d1c3

Nicklason merged commit bdfb9ee into development Apr 12, 2020

Nicklason deleted the review-offers branch April 12, 2020 14:57

Conversation

Nicklason commented Mar 4, 2020

Uh oh!

idinium96 commented Mar 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nicklason commented Mar 5, 2020

Uh oh!

Nicklason commented Mar 5, 2020

Uh oh!

idinium96 commented Mar 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

idinium96 commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nicklason commented Mar 6, 2020

Uh oh!

idinium96 commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

idinium96 commented Mar 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

idinium96 commented Mar 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

idinium96 commented Mar 18, 2020

Uh oh!

idinium96 commented Mar 26, 2020

Uh oh!

idinium96 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

idinium96 commented Apr 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

idinium96 commented Apr 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dex-Mori commented Apr 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

idinium96 commented Mar 5, 2020 •

edited

Loading

idinium96 commented Mar 5, 2020 •

edited

Loading

idinium96 commented Mar 6, 2020 •

edited

Loading

idinium96 commented Mar 6, 2020 •

edited

Loading

idinium96 commented Mar 7, 2020 •

edited

Loading

idinium96 commented Mar 10, 2020 •

edited

Loading

idinium96 left a comment •

edited

Loading

idinium96 commented Apr 10, 2020 •

edited

Loading

idinium96 commented Apr 10, 2020 •

edited

Loading

Dex-Mori commented Apr 10, 2020 •

edited

Loading