Merged
Conversation
If there is an AnalysisRow in the list of analysisPageRows that has a time of 0, then that leads to NaN being printed on screen. This occurs when an event has started, but has not completed, since the startTime and endTime is set to the same value.
…eText into its own file. Use NothingHereText if there are no rows to show.
Owner
Author
|
New tests are being run in the new build. Hooray! Previous build output: 21 tests run |
NicksPatties
commented
Jul 15, 2022
app/src/main/java/com/nickspatties/timeclock/ui/components/NothingHereText.kt
Show resolved
Hide resolved
app/src/main/java/com/nickspatties/timeclock/ui/pages/AnalysisPage.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nickspatties/timeclock/ui/pages/AnalysisPage.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nickspatties/timeclock/ui/pages/AnalysisPage.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nickspatties/timeclock/ui/viewmodel/AnalysisRow.kt
Outdated
Show resolved
Hide resolved
NicksPatties
commented
Jul 15, 2022
app/src/main/java/com/nickspatties/timeclock/ui/pages/AnalysisPage.kt
Outdated
Show resolved
Hide resolved
NicksPatties
deleted the
11-bug-metrics-screen-counting-incomplete-events
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Related issue
Fixes issue #11
Screenshots
Starting with no events
Event in progress
Finishing an event
Testing