Move start and stop clock functionality to the ClockPageViewModelState#26
Merged
NicksPatties merged 2 commits intomasterfrom Aug 16, 2022
Merged
Move start and stop clock functionality to the ClockPageViewModelState#26NicksPatties merged 2 commits intomasterfrom
NicksPatties merged 2 commits intomasterfrom
Conversation
NicksPatties
commented
Aug 16, 2022
app/src/main/java/com/nickspatties/timeclock/ui/viewmodel/ClockPageViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/nickspatties/timeclock/ui/viewmodel/ClockPageViewModel.kt
Show resolved
Hide resolved
| return "0$digits" | ||
| } | ||
|
|
||
| // TODO may need to make onClockStart and onClockStop suspend functions so they can properly |
Owner
Author
There was a problem hiding this comment.
Perhaps something I can do at a later time, but at the same time, I wan't the app to be very snappy and reactive, so saving the event data can happen separately, but if there's something that goes wrong, I should just call another function in the ViewModelState that resets the state of variables if saving goes wrong. Something to think about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Related issue
#24
continuation of #25
Testing