fix: NativeAOT - replace reflection-based XAML bindings in SettingsPage#117
Merged
fix: NativeAOT - replace reflection-based XAML bindings in SettingsPage#117
Conversation
Merged
…NativeAOT compatibility Co-authored-by: nlogozzo <17648453+nlogozzo@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix crash in WinUI settings page for NativeAOT app
fix: NativeAOT - replace reflection-based XAML bindings in SettingsPage
Mar 20, 2026
nlogozzo
approved these changes
Mar 20, 2026
Member
|
@copilot I merged in this change, but seeing |
nlogozzo
added a commit
that referenced
this pull request
Mar 21, 2026
* feat: Update deps * Fix IL3050 NativeAOT warnings in WinUI and GNOME Program.cs (#115) * Initial plan * Fix IL3050 NativeAOT warnings by adding RequiresDynamicCode attribute to Main methods Co-authored-by: nlogozzo <17648453+nlogozzo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nlogozzo <17648453+nlogozzo@users.noreply.github.com> * fix: Sources * fix: NativeAOT - replace reflection-based XAML bindings in SettingsPage (#117) * Initial plan * fix: replace DisplayMemberPath with compiled x:Bind ItemTemplate for NativeAOT compatibility Co-authored-by: nlogozzo <17648453+nlogozzo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nlogozzo <17648453+nlogozzo@users.noreply.github.com> * feat: Update license * fix: Missing sources * feat: Bindable item * feat: Update deps --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: nlogozzo <17648453+nlogozzo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DisplayMemberPath="Label"on the Theme and TranslationLanguageComboBoxes uses reflection at runtime, which is trimmed in NativeAOT builds, causing WMC1510 warnings and a crash when opening the settings page.Changes
SettingsPage.xaml: ReplaceDisplayMemberPath="Label"with compiledItemTemplates usingx:Bindandx:DataType="desktopapp:ISelectionItem"(Nickvision.Desktop.Application.ISelectionItem), generating property access code at build time instead of via reflection.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.