Default to libsecret if not Win32 or Apple, allow using it on Apple as an option#48
Merged
nlogozzo merged 2 commits intoNickvisionApps:mainfrom Nov 14, 2024
Merged
Conversation
Member
|
Thank you for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gnome libs are not really Linux-specific, they work on all Unix-like systems. Currently it is unclear how the code gonna compile on *BSD, for example. It is also unnecessary to prohibit using
libsecreton Apple. Besides testing, there is another reason for that: current implementation is broken on macOS < 10.7, so on older systemslibsecretis the only option really (unless Apple native code is fixed for those OS, but that is not something I am ready to work on).