Merged
Conversation
325ae36 to
e59e971
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We support three client libraries, but CI currently reports them under one combined
client-smokejob. That makes failures harder to triage and hides per-client status.PR #84 had the right direction, but it is stale/conflicting. This is a clean current-main replacement with intentionally small scope.
What changes
Replaces
client-smokewith separate jobs:Python client testsGo client testsTypeScript client testsEach job gets its own fresh PostgreSQL 18 container, installs
sql/pgque.sql, and setsPGQUE_TEST_DSN.Suites run:
go test -race -v ./...pytest -v clients/python/tests/bun run testAlso uses
set -Eeuo pipefailin the new shell blocks and a Python venv to avoid PEP 668/system-pip issues.Local validation
test,python-client-tests,go-client-tests,typescript-client-tests,verifygo test -raceis left to CI. Separate post-159 validation did run full Go tests against fresh PG18 successfully.