This repository was archived by the owner on Jul 13, 2025. It is now read-only.
add ParameterBuilderBase class for manual inclusion of parameters#119
Merged
add ParameterBuilderBase class for manual inclusion of parameters#119
ParameterBuilderBase class for manual inclusion of parameters#119Conversation
in simple terms, we have a dictionary where keys are the string name of possible responses from the user which are actually the person sending the invitation letter. The values, are out domain expert knowledge of the importance of that response, analguous to XAI values.
These is a value check for `_modifiers` where take a percent base value, and should return percent base value. This method is directly used by `potential` and `probability`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110
Summary
This PR creates the abstract classes needed for insertion of parameters (model features) manually.
For adding a new parameter, just extend the
ParameterBuilderBaseclass, and provide the possible values it can take and their importance. Then, everything is handled by_modifierclasses.Remarks
I should NOT have added the constants for invitation letter states, yet I forgot. in simple terms, we have a dictionary where keys are the string name of possible responses from the user which are actually the person sending the invitation letter. The values, are out domain expert knowledge of the importance of that response, analogous to XAI values.
These constants need to be moved to #112.