This repository was archived by the owner on Jul 13, 2025. It is now read-only.
Conversation
`"base"` represents the overall negative effect of something if it does not exist.
the new equation takes another value (on top of old definition) which allows proportional shifting. This allowed us to move values closer to the "base" state. (value of "base" is used as the shift). Thanks to this change, refinement of other responses importance values is no longer needed.
Since we use an instance of `ParameterBuilderBase` for each manual parameter that we want to include, it is required to update all calls to `extend_mean` with this new `shift` value which is filled with the value of `"base"` from corresponding constants in `vizard.models.estimators.manual.constant`. (Tests included)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
Summary
"none""base"case:"base"represents the overall negative effect of something if it does not exist. (dc44255)extend_mean) (0475252)"base"state. I.e., the value of"base"is used as theshift. (0475252)"base"value asshiftin allParameterBuilderinstances: Since we use an instance ofParameterBuilderBasefor each manual parameter that we want to include, it is required to update all calls toextend_meanwith this newshiftvalue which is filled with the value of"base"from corresponding constants invizard.models.estimators.manual.constant. (59cc7f3)"base"scenario and"none"scenario. (59cc7f3)