Sync Committee: Batch Metrics + Lag Tracker #698
Conversation
zadykian
force-pushed
the
sync-committee/batch-metrics
branch
from
5a4d78d to
813819b
Compare
zadykian
force-pushed
the
sync-committee/batch-metrics
branch
2 times, most recently
from
5a4d78d to
aedadff
Compare
zadykian
force-pushed
the
sync-committee/batch-metrics
branch
from
aedadff to
769f8cc
Compare
akokoshn
left a comment
akokoshn
left a comment
There was a problem hiding this comment.
May be keep aggregator in core directory and move lag_tracker to the metrics
Changed block-related metrics published by `Sync Committee` to match the new batching model: * Replaced `totalMainBlocksFetched` metric with `totalBatchesCreated` (counter); * Fixed the way `batchSizeBlocks` metric is collected (moved it to `RecordBatchCreated` method); * Replaced `txPerSingleProposal` metric published by `Proposer` with `batchSizeTxs` updated by `Aggregator`; * Renaming: `total_l1_tx_sent` -> `total_l1_state_updates`; `block_total_time_ms` -> `batch_total_proof_time_ms`;
Implemented new background worker to track per-shard block fetching lag and publish corresponding metrics to `SigNoz` * Defined `LagTracker` - new `Sync Committee` worker, responsible for fetching lag tracking; * Extended `SyncCommitteeMetricsHandler` with new `blockFetchingLag` metric;
zadykian
force-pushed
the
sync-committee/batch-metrics
branch
from
769f8cc to
ea3fed9
Compare
Package I think And I'd like to keep |
akokoshn
left a comment
akokoshn
left a comment
There was a problem hiding this comment.
Another idea - rename fetching to aggregator, but up to you)
| ) | ||
|
|
||
| lagTracker := fetching.NewLagTracker( | ||
| client, blockStorage, metricsHandler, fetching.NewDefaultLagTrackerConfig(), logger, |
There was a problem hiding this comment.
nice to have pass LagTrackerConfig options from command line
There was a problem hiding this comment.
I think we can do it later if needed, for now let's keep configuration as compact as possible
Block Metrics Adjustments
Changed block-related metrics published by
Sync Committeeto match the new batching model:totalMainBlocksFetchedmetric withtotalBatchesCreated(counter);batchSizeBlocksmetric is collected (moved it toRecordBatchCreatedmethod);txPerSingleProposalmetric published byProposerwithbatchSizeTxsupdated byAggregator;total_l1_tx_sent->total_l1_state_updates;block_total_time_ms->batch_total_proof_time_ms;Block Fetching Lag Tracker
Implemented new background worker to track per-shard block fetching lag and publish corresponding metrics to
SigNoz. By default, lag metrics are collected every 5 minutesLagTracker- newSync Committeeworker, responsible for fetching lag tracking;SyncCommitteeMetricsHandlerwith newblockFetchingLagmetric;