fix: sync periodically and only mint if budget ran out#63
Merged
mfontanini merged 2 commits intomainfrom Jan 30, 2026
Merged
Conversation
jcabrero
reviewed
Feb 2, 2026
| let has_new_deposit = balance > accounted; | ||
|
|
||
| let token_ctx = self.fetch_token_context(reward_address).await?; | ||
| let should_unlock = if remaining > U256::ZERO { |
Member
There was a problem hiding this comment.
If the remaining rewards are 0 (which, though being extremely unlikely, it is feasible), would we never unlock rewards? If rewards are 0, we're always getting should_unlock = false and thus never executing reward_policy.sync()
Member
Author
There was a problem hiding this comment.
remaining points to the rewards that are locked and need unlocking. If those are 0 then it means the keeper hasn't done the mint call on the L1 contract. Which is fine, eventually it should do that. Once we run out budget, a few lines above, this cache is reset so I think we're safe. I do want to change this caching thing because I find it a bit confusing but I think it's functionally correct now. Maybe @tlitre wants to have another look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the keeper logic so that:
syncperiodically if we have a new deposit we haven't accounted for. This ensures we don't sit around without syncing for too long. This also allows simplifying the code quite a bit since we don't have to account for syncing on a per reward distribution basis.