feat: ERC 8004 validations responses#70
Open
jcabrero wants to merge 3 commits intofeat/erc_8004_validationsfrom
Open
feat: ERC 8004 validations responses#70jcabrero wants to merge 3 commits intofeat/erc_8004_validationsfrom
jcabrero wants to merge 3 commits intofeat/erc_8004_validationsfrom
Conversation
jcabrero
force-pushed
the
feat/erc_8004_validations_responses
branch
from
0adce29 to
cd5bad6
Compare
jcabrero
commented
Feb 5, 2026
Member
Author
There was a problem hiding this comment.
Side error found. Needs to be 1 for our testnet to accept the transaction
jimouris
approved these changes
Feb 5, 2026
Comment on lines
+188
to
+190
| 0 => 50, // inconclusive | ||
| 1 => 100, // valid | ||
| 2 => 0, // invalid |
mfontanini
approved these changes
Feb 5, 2026
| impl Erc8004Metrics { | ||
| fn new(meter: &Meter) -> Self { | ||
| let events_received = meter | ||
| .u64_counter("blacklight.keeper.erc8004.events.received") |
Member
There was a problem hiding this comment.
Can you reuse L2EventMetrics::inc_events_received for this one? This way we'll have all events under the same metric
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.