chore: restructured node#71
Open
jcabrero wants to merge 2 commits intofeat/erc_8004_validations_responsesfrom
Open
chore: restructured node#71jcabrero wants to merge 2 commits intofeat/erc_8004_validations_responsesfrom
jcabrero wants to merge 2 commits intofeat/erc_8004_validations_responsesfrom
Conversation
mfontanini
approved these changes
Feb 5, 2026
jimouris
approved these changes
Feb 5, 2026
Member
jimouris
left a comment
There was a problem hiding this comment.
Looks good, but didn't check too thoroughly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by @mfontanini PR for the keeper, created this to simplify the structure of the blacklight-node and make it more readable.
tokio::Notifywith atokio_utils::cancellation_signalthat should tell the node to interrupt the listening task. In this case it was working because there is always a listening for cancellation event and only once concurrent tokio::select! waiting for the cancellation signal. It would have worked withnotify_oncebut I believe it is more solid using a cancellation signal in case the node was ever doing more than one listening event in parallel.supervisormodule, which runs the main loop and is in charge of client reconnections in case of failures.