-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moonfire-nvr: init at 0.7.6 #243261
moonfire-nvr: init at 0.7.6 #243261
Conversation
04fe6f3
to
0268f50
Compare
0268f50
to
1633730
Compare
1633730
to
2fe1897
Compare
2fe1897
to
0452202
Compare
|
||
postInstall = '' | ||
mkdir -p $out/lib/ui | ||
ln -s ${ui} $out/lib/ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the comment after this is merged, but how do you use the UI path that this creates?
For me, I have to specify uiDir = "${pkgs.moonfire-nvr}/lib/ui/jhbw1r5q3vsp886vvg72wbgwaypp391x-moonfire-nvr-ui-0.7.7";
to get it to work.
This seems awkward and crucially like it is not a stable file path.
Is this a bug? But then I'm not sure how this was a bug as presumably this wasn't committed without being tried? :S
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same problem. This seems wrong to me as well.
@gaelreyrol Can you clarify if this symlink was intended?
/nix/store/c0v8rfg69c042ck81vbmfhqgmlsbp2jd-moonfire-nvr-0.7.7/lib/ui/n9c8ijzh0ndgp6s5h88ix41wfhfxycpz-moonfire-nvr-ui-0.7.7 -> /nix/store/n9c8ijzh0ndgp6s5h88ix41wfhfxycpz-moonfire-nvr-ui-0.7.7/
Shouldn't it be
/nix/store/c0v8rfg69c042ck81vbmfhqgmlsbp2jd-moonfire-nvr-0.7.7/lib/ui -> /nix/store/n9c8ijzh0ndgp6s5h88ix41wfhfxycpz-moonfire-nvr-ui-0.7.7/
?
Because the path is not stable across updates, it makes it impossible to write a config or NixOS service for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect it should be:
mkdir -p $out/lib
ln -s ${ui} $out/lib/ui
Description of changes
This PR adds the package moonfire-nvr: https://github.com/scottlamb/moonfire-nvr
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)