Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moonfire-nvr: init at 0.7.6 #243261

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

gaelreyrol
Copy link
Contributor

Description of changes

This PR adds the package moonfire-nvr: https://github.com/scottlamb/moonfire-nvr

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@gaelreyrol gaelreyrol self-assigned this Jul 13, 2023
@gaelreyrol gaelreyrol force-pushed the moonfire-nvr-init-0.7.6 branch 2 times, most recently from 04fe6f3 to 0268f50 Compare July 13, 2023 15:10
@gaelreyrol gaelreyrol marked this pull request as ready for review July 13, 2023 16:22
pkgs/misc/moonfire-nvr/default.nix Outdated Show resolved Hide resolved
pkgs/misc/moonfire-nvr/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit d0a7ba0 into NixOS:master Jul 24, 2023
7 of 8 checks passed
@gaelreyrol gaelreyrol deleted the moonfire-nvr-init-0.7.6 branch July 24, 2023 23:11

postInstall = ''
mkdir -p $out/lib/ui
ln -s ${ui} $out/lib/ui
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the comment after this is merged, but how do you use the UI path that this creates?

For me, I have to specify uiDir = "${pkgs.moonfire-nvr}/lib/ui/jhbw1r5q3vsp886vvg72wbgwaypp391x-moonfire-nvr-ui-0.7.7"; to get it to work.

This seems awkward and crucially like it is not a stable file path.

Is this a bug? But then I'm not sure how this was a bug as presumably this wasn't committed without being tried? :S

Copy link
Contributor

@nh2 nh2 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem. This seems wrong to me as well.

@gaelreyrol Can you clarify if this symlink was intended?

/nix/store/c0v8rfg69c042ck81vbmfhqgmlsbp2jd-moonfire-nvr-0.7.7/lib/ui/n9c8ijzh0ndgp6s5h88ix41wfhfxycpz-moonfire-nvr-ui-0.7.7 -> /nix/store/n9c8ijzh0ndgp6s5h88ix41wfhfxycpz-moonfire-nvr-ui-0.7.7/

Shouldn't it be

/nix/store/c0v8rfg69c042ck81vbmfhqgmlsbp2jd-moonfire-nvr-0.7.7/lib/ui -> /nix/store/n9c8ijzh0ndgp6s5h88ix41wfhfxycpz-moonfire-nvr-ui-0.7.7/

?

Because the path is not stable across updates, it makes it impossible to write a config or NixOS service for it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it should be:

    mkdir -p $out/lib
    ln -s ${ui} $out/lib/ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants