Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcv-rack: 2.4.1 -> 2.5.1 #306692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ddelabru
Copy link
Contributor

@ddelabru ddelabru commented Apr 25, 2024

Description of changes

Changelog: https://github.com/VCVRack/Rack/blob/v2.5.1/CHANGELOG.md#251-2024-04-16

I compared dependency sources against the .gitmodules file in Rack repo v.2.5.1, and made any necessary updates to ensure each one is pulling in the commit that was most recent on the date of the Rack v.2.5.1 release. This skips v2.5.0, which introduced some new features but also a few bugs which are fixed in the newer version.

Things done

Tested ./result/bin/Rack and it seemed to work just fine on XFCE. I got a fatal GLFW initialization error on sway, but I believe this to be caused by a mismatch between the glfw-wayland version on my base system and in nixpkgs unstable.

Edited to add: I got this to run on sway in NixOS 23.11 by modifying the derivation slightly to build against glfw in the stable NixOS channel instead of glfw from unstable nixpkgs, so this confirms for me that the issue I experienced is about a glfw API mismatch in my build environment and not an issue with the derivation itself.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@ddelabru
Copy link
Contributor Author

@wegank, thank you for the v2.4.1 update and apologies that I didn't get to it at the time. Also heads up to @jpotier and @nathyong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant