vcv-rack: 2.4.1 -> 2.5.1 #306692
Merged
vcv-rack: 2.4.1 -> 2.5.1 #306692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
|
the GLFW init error should be fixed by #323510 |
|
Also, I think you can get away with setting |
jpotier
approved these changes
Jul 25, 2024
|
Friendly ping to @ddelabru on this 🙂 |
|
Result of 1 package built:
|
afh
approved these changes
Aug 4, 2024
afh
added
the
12.approvals: 2
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1886 |
13 tasks
|
Would be be willing to help getting this merged, @JohnRTitor? |
|
Result of 1 package built:
|
|
Thanks for much for helping getting this merged, @JohnRTitor, very helpful and very much appreciated 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changelog: https://github.com/VCVRack/Rack/blob/v2.5.1/CHANGELOG.md#251-2024-04-16
I compared dependency sources against the .gitmodules file in Rack repo v.2.5.1, and made any necessary updates to ensure each one is pulling in the commit that was most recent on the date of the Rack v.2.5.1 release. This skips v2.5.0, which introduced some new features but also a few bugs which are fixed in the newer version.
Things done
Tested ./result/bin/Rack and it seemed to work just fine on XFCE. I got a fatal GLFW initialization error on sway, but I believe this to be caused by a mismatch between the glfw-wayland version on my base system and in nixpkgs unstable.
Edited to add: I got this to run on sway in NixOS 23.11 by modifying the derivation slightly to build against glfw in the stable NixOS channel instead of glfw from unstable nixpkgs, so this confirms for me that the issue I experienced is about a glfw API mismatch in my build environment and not an issue with the derivation itself.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.