Add data-page attribute for E2E test selectors#46
Merged
dtkav merged 2 commits intoNo-Instructions:mainfrom Feb 3, 2026
Merged
Add data-page attribute for E2E test selectors#46dtkav merged 2 commits intoNo-Instructions:mainfrom
dtkav merged 2 commits intoNo-Instructions:mainfrom
Conversation
Adds a data-page attribute to the settings container that exposes which view is currently active. This gives E2E tests a stable way to detect the current page without fingerprint-matching on content. Values: relay-home, relay-detail, folder-detail, shared-folder-orphan No user-visible changes - just a data attribute for test automation.
dtkav
requested changes
Feb 2, 2026
Member
dtkav
left a comment
dtkav
left a comment
There was a problem hiding this comment.
Slight mod -- it would be better if these were in the pages themselves:
Add data-view attributes to each settings view for stable E2E test selectors.
| View | Component | Attribute |
|---|---|---|
| Home | Relays.svelte |
data-view="relays" |
| Manage Relay | ManageRelay.svelte |
data-view="manage-relay" |
| Manage Shared Folder | ManageSharedFolder.svelte |
data-view="manage-shared-folder" |
| Manage Remote Folder | ManageRemoteFolder.svelte |
data-view="manage-remote-folder" |
Usage in tests:
await page.locator('[data-view="manage-relay"]').waitFor();
Per review feedback, each view component now owns its own data-view attribute rather than having the parent calculate it. This is cleaner because: - Each component owns its identity - No central routing logic needed for test selectors - Adding new views doesn't require touching PluginSettings Attributes: - Relays.svelte: data-view="relays" - ManageRelay.svelte: data-view="manage-relay" - ManageSharedFolder.svelte: data-view="manage-shared-folder" - ManageRemoteFolder.svelte: data-view="manage-remote-folder" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dtkav
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a data-page attribute to the settings container that exposes which view is currently active. This gives E2E tests a stable way to detect the current 'page' without fingerprint-matching on content.
Values: relay-home, relay-detail, folder-detail, shared-folder-orphan
No user-visible changes - just a data attribute for test automation.