Merged
Conversation
This has the benefit of using the user’s cookies from Safari, which avoids making you log into MS and SE in the app.
Owner
|
This is awesome! Thanks! The one thing I'm debating is the switch to an SFSafariViewController; I was thinking about adding some code to scrape the authentication code out of the "success" page, and IIRC an SFSafariViewController won't give us access to that. Not having to type my password seems like a better option than not having to copy and paste a code though, so I think it's worth it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plus some other goodies 🎁