Skip to content

Conversation

@donovanh
Copy link
Collaborator

@donovanh donovanh commented Nov 8, 2019

Adds an overview of callbacks, promises, async await.

Includes a "show solution" function and implementation.

Includes default instead of default.njk - will be easier to change templating in future if need be.

@donovanh donovanh added the article Adding content label Nov 8, 2019
Copy link
Collaborator

@readikus readikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Fantastic bit of writing and teaching.

I'm not sure it's linked from the menu?

Copy link
Collaborator

@jjmax75 jjmax75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @donovanh
I started reviewing but will wait for Ian's review to go through
Looks good though, great start

@donovanh
Copy link
Collaborator Author

Note @readikus I'd like to redo the menu to use a data object and a loop rather than the current copy pasta - should be another PR though

@donovanh donovanh force-pushed the control-flow branch 3 times, most recently from a5fb5cb to 979c679 Compare November 13, 2019 19:15
@readikus readikus merged commit 2cf9010 into master Nov 14, 2019
@readikus readikus deleted the control-flow branch November 14, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

article Adding content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants