Skip to content

Adding prettierrc with some initial rules #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

Adding prettierrc with some initial rules #19

merged 1 commit into from
Nov 13, 2019
+24 −18

Conversation

@donovanh
Copy link
Collaborator

@donovanh donovanh commented Nov 12, 2019

Does this work for everyone?

{
  "trailingComma": "es5",
  "tabWidth": 2,
  "semi": true,
  "singleQuote": true
}

jjmax75
jjmax75 approved these changes Nov 13, 2019
View reviewed changes
Copy link
Collaborator

@jjmax75 jjmax75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no complaints, two spaces, single quotes and semi, trailing comma,

plus the 80 chars line length!

@jjmax75 jjmax75 self-assigned this Nov 13, 2019
@jjmax75
Copy link
Collaborator

jjmax75 commented Nov 13, 2019

@donovanh there are conflicts there now after the last merge, I had a look but was unsure of what to do, let me know when it's sorted and I'll merge

@jjmax75 jjmax75 merged commit 8735407 into master Nov 13, 2019
@jjmax75 jjmax75 deleted the prettier branch November 13, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjmax75 jjmax75 jjmax75 approved these changes

Assignees

@jjmax75 jjmax75

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@donovanh @jjmax75