Conversation
Member
|
Pls separate in separate prs. |
Member
|
Pls separate in smaller prs. |
1 similar comment
Member
|
Pls separate in smaller prs. |
MakMuftic
force-pushed
the
mmuftic/register-endpoint
branch
from
ed098f3 to
41d3bae
Compare
mpetrun5
reviewed
Sep 11, 2020
mpetrunic
requested changes
Sep 11, 2020
mpetrunic
approved these changes
Sep 15, 2020
mpetrun5
approved these changes
Sep 15, 2020
| return mr.Msg | ||
| } | ||
|
|
||
| func DecodeJSONBody(w http.ResponseWriter, r *http.Request, dst interface{}) error { |
Member
There was a problem hiding this comment.
We should probably write tests for this at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API routes setup PR:
/api/v1/nodes- register endpoint --> initial setup for Register endpoint #7