Skip to content

Optimize Dockerfile#14

Merged
MakMuftic merged 2 commits intomasterfrom
mmuftic/optimize-dockerfile
Sep 15, 2020
Merged

Optimize Dockerfile#14
MakMuftic merged 2 commits intomasterfrom
mmuftic/optimize-dockerfile

Conversation

@MakMuftic
Copy link
Copy Markdown
Member

@MakMuftic MakMuftic commented Sep 11, 2020 •
edited
Loading

Optimize Dockerfile PR:

  • replaced make commands with native go commands
  • final image only contains binary (uses scratch image as a starting point)

closes #13

@MakMuftic MakMuftic self-assigned this Sep 11, 2020
mpetrunic
mpetrunic reviewed Sep 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double check image is using non root user?

mpetrunic
mpetrunic reviewed Sep 11, 2020
View reviewed changes
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
@MakMuftic
Copy link
Copy Markdown
Member Author

MakMuftic commented Sep 14, 2020

Could you double check image is using non root user?

Do you mean for this final image that is built from scratch image?

@MakMuftic MakMuftic requested a review from mpetrunic September 14, 2020 12:33
@mpetrunic
Copy link
Copy Markdown
Member

mpetrunic commented Sep 14, 2020

Could you double check image is using non root user?

Do you mean for this final image that is built from scratch image?

Yes

@MakMuftic
Copy link
Copy Markdown
Member Author

MakMuftic commented Sep 15, 2020

This is ready for merge.

@MakMuftic MakMuftic merged commit c660c1c into master Sep 15, 2020
@MakMuftic MakMuftic deleted the mmuftic/optimize-dockerfile branch September 15, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

+1 more reviewer

@mpetrun5 mpetrun5 mpetrun5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MakMuftic MakMuftic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize Dockerfile

3 participants

@MakMuftic @mpetrunic @mpetrun5