Skip to content

TLS Verification Logic Improvements, Channel Initialization Consistency#86

Merged
4 commits merged intomainfrom
unknown repository
Jan 5, 2026
Merged

TLS Verification Logic Improvements, Channel Initialization Consistency#86
4 commits merged intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 5, 2026

This pull request introduces several documentation clarifications and code adjustments focused on TLS certificate verification logic (specifically for "TLS code-1") and the handling of project branding. The most significant changes include tightening the TLS verification flow to only apply to code-1, clarifying license and trademark usage in documentation.

TLS Verification Logic Improvements:

  • Refined TLS verification logic throughout internal/common.go and related files to only apply to "tlsCode == '1'", removing support for "tlsCode == '2'" in this context and improving log messages to clarify when RAM certificate verification is used. [1] [2] [3] [4] [5]
  • Added logic to regenerate RAM certificates with TLS 1.3 when using "tlsCode == '1'" in the server handshake, and improved error handling and logging around this process in internal/server.go.

Channel Initialization Consistency:

  • Standardized initialization of verifyChan in both client and server constructors, moving away from conditional creation to always initializing this channel. [1] [2]
  • Removed redundant or now-unnecessary conditional channel creation during tunnel handshake setup. [1] [2]

Documentation and Branding:

  • Updated both README.md and README_zh.md to clarify that the BSD 3-Clause License applies only to the source code, and that the NodePass name, logo, and official identity are not covered by the code license and require explicit authorization for use. [1] [2]

Dependency Management:

  • Added import of the cert package to internal/server.go to support new TLS certificate logic.

@ghost ghost merged commit 8b79809 into NodePassProject:main Jan 5, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants