TLS Verification Logic Improvements, Channel Initialization Consistency#86
Merged
4 commits merged intomainfrom Jan 5, 2026
unknown repository
Merged
TLS Verification Logic Improvements, Channel Initialization Consistency#864 commits merged intomainfrom unknown repository
4 commits merged intomainfrom
unknown repository
Conversation
added 4 commits
January 4, 2026 08:15
… in tunnel handshake for improved security control
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several documentation clarifications and code adjustments focused on TLS certificate verification logic (specifically for "TLS code-1") and the handling of project branding. The most significant changes include tightening the TLS verification flow to only apply to code-1, clarifying license and trademark usage in documentation.
TLS Verification Logic Improvements:
internal/common.goand related files to only apply to"tlsCode == '1'", removing support for"tlsCode == '2'"in this context and improving log messages to clarify when RAM certificate verification is used. [1] [2] [3] [4] [5]"tlsCode == '1'"in the server handshake, and improved error handling and logging around this process ininternal/server.go.Channel Initialization Consistency:
verifyChanin both client and server constructors, moving away from conditional creation to always initializing this channel. [1] [2]Documentation and Branding:
README.mdandREADME_zh.mdto clarify that the BSD 3-Clause License applies only to the source code, and that the NodePass name, logo, and official identity are not covered by the code license and require explicit authorization for use. [1] [2]Dependency Management:
certpackage tointernal/server.goto support new TLS certificate logic.