Skip to content

Conversation

@FredGuiou
Copy link
Contributor

@fraxken Here is this WIP to implement a theme management. The theme is configurable in settings. Could you please make a first review ?

@fraxken
Copy link
Member

fraxken commented May 30, 2025

Warnings in home page probably need a bit of work:

image

separator and title too:

image

packages navigation doesn't pair well in dark

image

search page:

image

@PierreDemailly
Copy link
Member

The legend is broken with dark theme because FRIENDLY is missing (only available with light theme).

@PierreDemailly
Copy link
Member

For the search page, i think the color when hovering items could be fine as default (top is hover and bottom is default on the following screen)
image

@FredGuiou FredGuiou force-pushed the add-theme-selector-in-settings branch 3 times, most recently from 0f147f9 to bbaa514 Compare June 9, 2025 15:52
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (28ee6a9) to head (fd467e2).
Report is 190 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##            master     #494       +/-   ##
============================================
- Coverage   100.00%   83.78%   -16.22%     
============================================
  Files           15       29       +14     
  Lines          649     1973     +1324     
  Branches         0        1        +1     
============================================
+ Hits           649     1653     +1004     
- Misses           0      320      +320     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FredGuiou FredGuiou force-pushed the add-theme-selector-in-settings branch from bbaa514 to 161544f Compare June 9, 2025 16:37
@FredGuiou FredGuiou force-pushed the add-theme-selector-in-settings branch from 161544f to 159e39a Compare June 12, 2025 17:07
@PierreDemailly PierreDemailly marked this pull request as ready for review June 12, 2025 17:57
@FredGuiou FredGuiou force-pushed the add-theme-selector-in-settings branch from 159e39a to fd467e2 Compare June 13, 2025 10:14
@fraxken fraxken merged commit 7ac13c6 into NodeSecure:master Jun 13, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants