Skip to content

Conversation

@Mathieuka
Copy link
Contributor

No description provided.

Copy link
Member

@fraxken fraxken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the TypeScript definition file:

js-x-ray/index.d.ts

Lines 57 to 67 in f833d69

interface WarningsNames {
parsingError: "parsing-error",
unsafeImport: "unsafe-import",
unsafeStmt: "unsafe-stmt",
unsafeRegex: "unsafe-regex",
unsafeAssign: "unsafe-assign",
encodedLiteral: "encoded-literal",
shortIdentifiers: "short-identifiers",
suspiciousLiteral: "suspicious-literal",
obfuscatedCode: "obfuscated-code"
}

Maybe we can also add a section in README to explain how we can use CONSTANTS warnings with the i18n code ?

@Mathieuka Mathieuka force-pushed the enhance-exported-warnings-to-include-i18n-token branch from 4c2fa26 to f0923d5 Compare April 27, 2022 12:11
@Mathieuka Mathieuka force-pushed the enhance-exported-warnings-to-include-i18n-token branch 4 times, most recently from 0d543ce to 34f2af2 Compare April 27, 2022 12:27
@Mathieuka Mathieuka force-pushed the enhance-exported-warnings-to-include-i18n-token branch from 34f2af2 to c352306 Compare April 28, 2022 03:00
Copy link
Member

@fraxken fraxken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Kawacrepe Kawacrepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@fraxken fraxken merged commit 42a71d3 into NodeSecure:master May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants