-
Notifications
You must be signed in to change notification settings - Fork 31
Enhance exported warnings to include i18n token #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance exported warnings to include i18n token #23
Conversation
fraxken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update the TypeScript definition file:
Lines 57 to 67 in f833d69
| interface WarningsNames { | |
| parsingError: "parsing-error", | |
| unsafeImport: "unsafe-import", | |
| unsafeStmt: "unsafe-stmt", | |
| unsafeRegex: "unsafe-regex", | |
| unsafeAssign: "unsafe-assign", | |
| encodedLiteral: "encoded-literal", | |
| shortIdentifiers: "short-identifiers", | |
| suspiciousLiteral: "suspicious-literal", | |
| obfuscatedCode: "obfuscated-code" | |
| } |
Maybe we can also add a section in README to explain how we can use CONSTANTS warnings with the i18n code ?
4c2fa26 to
f0923d5
Compare
0d543ce to
34f2af2
Compare
34f2af2 to
c352306
Compare
fraxken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kawacrepe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat!
No description provided.