-
Notifications
You must be signed in to change notification settings - Fork 31
Add tests around probes #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@fraxken Hey, before adding others tests, I wanna know if I'm on the right path (since I just get into this project :) ) |
|
@fraxken Hey, est-ce que tu valides le flow de test ? Je pense qu'à terme on aura des petits utils pour vérifier les comportements spécifiques de certaines probes (je pense à isMemberExpression qui ajoute des dependencies, isBinary qui tape sur les .counter etc... Mais ça montre l'idée générale et permettra de faire des petites PR pour ajouter des cas de tests, sans avoir à trop se prendre la tête, non? EDIT: je pense qu'il serait même intéressant d'ajouter un README.md dans le dossier des tests pour expliquer le flow, les différents tests etc... |
|
Yes, seems ok to me! |
|
@all-contributors please add @Kawacrepe for code, test |
|
I've put up a pull request to add @Kawacrepe! 🎉 |
Hey!
Here is a PR, adding test around unsafeCallee.
It aims to add some tests around probes, according to this issue #24, but as you may understand, I do not want to add all tests case inside 1 PR.
Furthermore, it would allow us to onboard people on js-x-ray, since they will get an example, about how we want to test the probes.