refactor: implement new VariableTracer #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-go
approved these changes
Nov 2, 2022
Member
tony-go
left a comment
tony-go
left a comment
There was a problem hiding this comment.
LGTM 🎉
I'd prefer to see the test I mentioned before we merge this, but it's up to you. 🙌
Thanks for the investment you put into that project. Can't wait to read more about the code in ast-utils.
fraxken
force-pushed
the
variable-tracer-final
branch
from
552af91 to
9fcc1e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalize the implementation of the new NodeSecure VariableTracer class. Two probes already use it:
A lot of code has been removed because the old mechanism was no more useful.
This PR also include a Major (breaking) changes by totally removing the
unsafe-assignwarning. This one was related to the old mechanism and I think most of the warnings were not relevant in the real world.Because initial implementation were not capable to catch a lot of situations I added this warning but now the Tracer is quite capable. So I think removing it will greatly help our tools like CI and avoid to match warnings in the UI.