Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/social-swans-add.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nodesecure/scanner": minor
---

feat(extractors): keep only wanted flags
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Import Third-party Dependencies
import FrequencySet from "frequency-set";
import { getFlags } from "@nodesecure/flags";

// Import Internal Dependencies
import type {
Expand All @@ -11,6 +12,9 @@ export type FlagsResult = {
flags: Record<string, number>;
};

// CONSTANTS
const kWantedFlags = getFlags();

export class Flags implements ManifestProbeExtractor<FlagsResult> {
level = "manifest" as const;

Expand All @@ -22,7 +26,11 @@ export class Flags implements ManifestProbeExtractor<FlagsResult> {
) {
const { flags } = version;

flags.forEach((flagName) => this.#flags.add(flagName));
flags.forEach((flagName) => {
if (kWantedFlags.has(flagName)) {
this.#flags.add(flagName);
}
});
}

done() {
Expand Down
2 changes: 1 addition & 1 deletion workspaces/scanner/test/extractors/payload.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ describe("Extractors.Probes", () => {
});

describe("Flags", () => {
it("should extract strnum flags", () => {
it("should extract strnum known flags", () => {
const extractor = new Extractors.Payload(
strnumNodesecurePayload,
[
Expand Down
3 changes: 2 additions & 1 deletion workspaces/scanner/test/fixtures/extractors/strnum.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"flags": [
"hasWarnings",
"isOutdated",
"hasManyPublishers"
"hasManyPublishers",
"hasDependencies"
],
"warnings": [
{
Expand Down