Skip to content

Conversation

@fraxken
Copy link
Member

@fraxken fraxken commented Nov 28, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025

🦋 Changeset detected

Latest commit: ebde033

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nodesecure/scanner Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot finished reviewing on behalf of fraxken November 28, 2025 11:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a breaking change that refactors the payload structure to include both name and version information in a rootDependency object, replacing the previous rootDependencyName string field.

  • Replaces rootDependencyName string with rootDependency object containing name and version properties
  • Simplifies version extraction in comparePayloads by accessing version directly from rootDependency instead of extracting from dependencies map
  • Updates all test fixtures and test assertions to reflect the new structure

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
workspaces/scanner/src/types.ts Updates Payload interface to define rootDependency as an object with name and version properties
workspaces/scanner/src/depWalker.ts Creates rootDependency object with name and version from manifest, using defaults for workspaces
workspaces/scanner/src/comparePayloads.ts Simplifies version extraction by accessing rootDependency.version directly instead of parsing dependencies map
workspaces/scanner/test/depWalker.spec.ts Updates test assertions to check for rootDependency object and validates its structure
workspaces/scanner/test/fixtures/scannerPayloads/*.json Updates all test payload fixtures to use new rootDependency object structure
workspaces/scanner/test/fixtures/extractors/*.json Updates extractor test fixtures to use new rootDependency object structure
.changeset/tough-colts-taste.md Documents the breaking change with major version bump

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fraxken fraxken merged commit c009145 into master Nov 28, 2025
11 checks passed
@fraxken fraxken deleted the payload-root-dependency branch November 28, 2025 13:41
@github-actions github-actions bot mentioned this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants