-
Notifications
You must be signed in to change notification settings - Fork 20
refactor(tree-walker): re-abstract tree loading #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0e844a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8ec0384 to
0ff4671
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors tree loading logic by introducing a TreeDependencies class to encapsulate dependency filtering and transformation. The main change abstracts the complexity of filtering Arborist nodes based on dev dependencies and workspace settings away from the walker implementation.
- Introduces
TreeDependenciesclass to handle dependency filtering from Arborist nodes - Updates
LocalDependencyTreeLoaderto returnTreeDependenciesinstead of rawArborist.Node - Adds comprehensive tests for
LocalDependencyTreeLoader
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
workspaces/tree-walker/src/npm/TreeDependencies.ts |
New class that encapsulates logic for filtering and transforming Arborist node edges into a Map of dependencies |
workspaces/tree-walker/src/npm/LocalDependencyTreeLoader.ts |
Updated to return TreeDependencies instead of Arborist.Node, with options now bundled into a single object |
workspaces/tree-walker/src/npm/walker.ts |
Refactored to use TreeDependencies API, simplifying the dependency iteration logic |
workspaces/tree-walker/test/npm/LocalDependencyTreeLoader.spec.ts |
New test file covering both virtual and actual tree loading scenarios |
workspaces/tree-walker/test/fixtures/tree-loader-virtual/package.json |
Test fixture for tree loading tests |
workspaces/tree-walker/test/fixtures/tree-loader-virtual/package-lock.json |
Lock file fixture for virtual tree loading test |
.changeset/yummy-knives-grab.md |
Changeset documenting this as a minor version change |
Files not reviewed (1)
- workspaces/tree-walker/test/fixtures/tree-loader-virtual/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
workspaces/tree-walker/test/fixtures/tree-loader-virtual/package-lock.json
Outdated
Show resolved
Hide resolved
0ff4671 to
0e844a4
Compare
No description provided.