(mama) utils to detect lockfiles #576 #582
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 02913b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clemgbld
reviewed
Dec 8, 2025
Member
|
You need to add a changeset in minor |
fraxken
reviewed
Dec 12, 2025
Member
We can add deno.lock to the list |
fraxken
reviewed
Dec 17, 2025
Comment on lines
+18
to
+25
| const result: [string, string][] = []; | ||
| for (const [k, v] of LOCK_FILES) { | ||
| if (dir.includes(v)) { | ||
| result.push([k, v]); | ||
| } | ||
| } | ||
|
|
||
| return result.length === 0 ? null : result; |
Member
There was a problem hiding this comment.
You can use flatMap and Object.fromEntries at the end to transform the Array back into an Object.
| ["deno", "deno.lock"] | ||
| ]; | ||
|
|
||
| export function scanLockFiles(dirPath: string): null | object { |
Member
There was a problem hiding this comment.
object is not acceptable as type here
Member
|
Also please add documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.