-
Notifications
You must be signed in to change notification settings - Fork 4
feat(rewards): implement solo claims #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ETeissonniere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aliXsed can we at the very least agree to keep tests and scripts in solidity to be compatible with forge? It is ok if we have hardhat as an added compatibility layer but I'd like to remain 100% support for forge and not break apart our testing/scripting suite.
Sure, this is a draft just to test things and share my script with you while we were discussing the efficiency of batching. |
ETeissonniere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. Just suggested some miscellaneous cleanup though control logic looks fine from my pov.
"Reward(address recipient,uint256 amount,uint256 sequence)"which should be issued by an authorised oracle and signed off-chain based on EIP-712 for therewards.depin.nodledomain and the version "1" to be minted as NODL tokens for the recipient.mintRewardfails due toRewardQuotaExceeded, the submitter should wait forquotaRenewalTimestampto resubmit.