modify bridging nft to be soulbound and levels based #37
Conversation
ETeissonniere
commented
Jun 18, 2024
ETeissonniere
commented
- change meta
- introduce notion of levels and different token URIs
- move to a soulbound token
- remove unused batch
- holder limitation still allows for level ups
- integrate levels
- update deploy script
| - `N_TOKENS_URI`: URI of NFT metadata. | ||
| - `N_MAX_HOLDERS`: maximum number of participants | ||
| - `N_TOKENS_URI_ROOT`: URI of NFT metadata folder where each level metadata is later presented | ||
| - `N_LEVELS`: number of levels to set |
There was a problem hiding this comment.
Basically depending on how many tokens you bridge you get better looking NFTs. Idea from products.
There was a problem hiding this comment.
So perhaps it's better to be called N_AMOUNT_REUQIRED_FOR_RANK_0 or N_AMOUNTS_REQUIRED_FOR_RANKS
| N_LEVELS=3 \ | ||
| N_LEVELS_0=100 \ | ||
| N_LEVELS_1=200 \ | ||
| N_LEVELS_2=300 \ |
There was a problem hiding this comment.
It seems not very hard to have them as
N_LEVELS=100,200,300
then read it through vm.envString and parse it to an array. Just a nice to have suggestion.
There was a problem hiding this comment.
I agree but as far as I know this not quite doable without implementing string manipulation functions or using a library. Let me know if you can think of a straightforward way to do it
There was a problem hiding this comment.
I also think you would need to manipulate the string which is (processing wise) not bad for a deployment script
Co-authored-by: Alex Sedighi <alex@nodle.com>
