Skip to content

merge updates from NCAR/main#24

Merged
YanchunHe merged 115 commits intoNorESMhub:noresmfrom
llsuo:noresm
Mar 16, 2026
Merged

merge updates from NCAR/main#24
YanchunHe merged 115 commits intoNorESMhub:noresmfrom
llsuo:noresm

Conversation

@llsuo
Copy link
Collaborator

@llsuo llsuo commented Jan 13, 2026

This PR syncs the noresm branch with the latest updates from NCAR/ADF:main (111 commits).

All merge conflicts have been resolved, with key changes in:

scripts/plotting/global_mean_timeseries.py

scripts/analysis/amwg_table.py

lib/plotting_functions.py

I verified the merged version locally by running ./run_adf_diag in my conda environment, and the diagnostics completed successfully.

brianpm and others added 30 commits February 6, 2025 13:14
Adds the MOPITT plotting script that can be called from the config yaml file.
Adds the MOPITT entry in the 'plotting_scripts' section of the cam config file, and adds CO to the list of cam variables to plot.
@llsuo llsuo requested a review from YanchunHe January 13, 2026 15:43
@YanchunHe
Copy link
Collaborator

Thanks a lot, @llsuo
see ADF has v1.0.0 now, but we have v0.13 installed on NIRD. I need to install the new version before I can merge this.

@llsuo
Copy link
Collaborator Author

llsuo commented Jan 20, 2026

I ran it in adf_v0.13 and it worked, and it’d be great to have it running on adf_v1.00.

@TomasTorsvik
Copy link

@llsuo , @YanchunHe - it would be great if we could update and merge this. The diff is currently 114 commits, so not much different from in January. I'm happy to help with this, if there is some way I can contribute.

@YanchunHe
Copy link
Collaborator

@TomasTorsvik Thanks very much!

Could you help to run the ADF with llsuo's main branch, and test it works properly with the current NorESM3 simulation?

@TomasTorsvik
Copy link

@llsuo , @YanchunHe
I was able to run the PR branch from @llsuo with some minor modifications.

  • The current ADF system includes a git_info part that does not work with the setup that I am using (not sure if this applies only to me, or in general for NorESM3). The problem is connected to the function get_git_info, which fails if no git repository is found, thereby crashing ADF. I can get around this problem by commenting out the calls to get_git_info in ADF/lib/adf_web.py, lines 252-257 and 292-298. There is probably a better solution, maybe a try .. except or something like this, but we might also just leave out the git info part.

  • The environment adf_v1.0.0 is identical to adf_v0.13, except for the name (i.e. all python packages are the same and with the same version numbers), hence there is no real need to change to adf_v1.0.0 for the environment.

Sample output is available here:
https://ns9560k.web.sigma2.no/datalake/diagnostics/noresm/tomast/testADF/n1850.ne30pg3_tn14.noresm3_0_beta11-run3_yr001.20260226/ADF/

@YanchunHe
Copy link
Collaborator

Hi @tomas, which script includes this git_info? I don't see if there is a local changes in this commit.

I made a test with this update, and don't find error for git_info.

And with the new yaml setting, it should contains more diagnostics.

https://ns2345k.web.sigma2.no/datalake/diagnostics/ADF/yanchun/n1850.ne30pg3_tn14.noresm3_0_beta12a-run1_yr001.20260313_1_10_vs_n1850.ne30_tn14.hybrid_fatessp.20241204_52_70/website/index.html

Please let me know if it looks good. I will then merge soon.

@TomasTorsvik
Copy link

@YanchunHe - If you did not get any errors with call to system git during testing, it is probably something connected to my setup that is wrong. The output looks fine to me, so I think this can be merged.

@TomasTorsvik TomasTorsvik self-requested a review March 16, 2026 12:20
Comment on lines +251 to +257
# Gather Git info
git_info = self.get_git_info()
f.write("\n")
f.write(f"<br><br><strong><a {font_22}>Git Info</a></strong><br>")
for key,val in git_info.items():
f.write(f"{two_space}<a {font_16}><strong>{key}:</strong> {val}</a></><br>")
f.write("</p>")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the first use of "get_git_info()"

Comment on lines +291 to +298
# Gather Git info
git_info = self.get_git_info()
git_msg = "\nGit Info:"
msg = f"{git_msg}\n{'-' * (len(git_msg)-1)}\n"
log_msg += f"\n {msg}"

for key,val in git_info.items():
log_msg += f" {key}: {val}\n"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here is the second use of "get_git_info()"

Copy link
Collaborator

@YanchunHe YanchunHe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and looks OK.

I will then leave the git_info part unchanged, since it seems to depend on the individual git environment.

Please use the updated config_noresm_default.yaml file.

@YanchunHe YanchunHe merged commit 2fc7021 into NorESMhub:noresm Mar 16, 2026
6 of 7 checks passed
@tomas
Copy link

tomas commented Mar 17, 2026

@YanchunHe please don't mention me in this repo again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants