Skip to content

added integer checks for budget and timeline impact inputs#113

Merged
jamescd18 merged 1 commit intodevelopfrom
#779-stop-decimal-inputs-CR
Aug 12, 2022
Merged

added integer checks for budget and timeline impact inputs#113
jamescd18 merged 1 commit intodevelopfrom
#779-stop-decimal-inputs-CR

Conversation

@glacierA
Copy link
Copy Markdown
Contributor

@glacierA glacierA commented Aug 12, 2022

…mpact

Changes

Added checks for integer values when creating change requests to prevent decimal inputs in Timeline/Budget Impact fields.

Notes

Any other notes go here

Test Cases

None (tests for create change request page seem scarce?)

Screenshots (if applicable)

Screen Shot 2022-08-11 at 1 09 35 AM

To Do

None? Does it make sense for things to only be integers? Should we allow people to add 1.5 weeks or a couple of cents to the budget?

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your squad if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors
  • No newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (if applicable)
  • Remove any not-applicable sections
  • Assign the PR to yourself
  • PR is linked to the ticket
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack

Closes #81

@glacierA glacierA self-assigned this Aug 12, 2022
jamescd18
jamescd18 approved these changes Aug 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jamescd18 jamescd18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamescd18 jamescd18 merged commit 3212ae5 into develop Aug 12, 2022
@jamescd18 jamescd18 deleted the #779-stop-decimal-inputs-CR branch August 12, 2022 02:21
anthonybernardi added a commit that referenced this pull request Aug 15, 2022
@anthonybernardi
Squashed commit of the following:
f16931b 
commit d6e6bd8
Author: anthonybernardi <anthony.bernardi09@gmail.com>
Date:   Mon Aug 15 17:14:43 2022 -0400

    login page back to normal

commit 84e91b3
Merge: b292924 1f8404d
Author: Anthony Bernardi <63663597+anthonybernardi@users.noreply.github.com>
Date:   Mon Aug 15 17:08:39 2022 -0400

    Merge pull request #120 from Northeastern-Electric-Racing/#119

    #119: better validation

commit b292924
Merge: 5109631 df3d390
Author: Anthony Bernardi <63663597+anthonybernardi@users.noreply.github.com>
Date:   Sun Aug 14 17:38:55 2022 -0400

    Merge pull request #121 from Northeastern-Electric-Racing/#66

    #66 - Risk Create Endpoint

commit df3d390
Author: anthonybernardi <anthony.bernardi09@gmail.com>
Date:   Sun Aug 14 14:58:01 2022 -0400

    #66 - added the endpoint and whatnot

commit 1f8404d
Author: Anthony Bernardi <bernardi.an@husky.neu.edu>
Date:   Sat Aug 13 12:34:14 2022 -0400

    tests

commit 557315a
Author: Anthony Bernardi <bernardi.an@husky.neu.edu>
Date:   Sat Aug 13 12:21:51 2022 -0400

    #119: better validation

commit 5109631
Merge: 123b2d7 c4214bc
Author: Anthony Bernardi <63663597+anthonybernardi@users.noreply.github.com>
Date:   Fri Aug 12 19:13:49 2022 -0400

    Merge pull request #116 from Northeastern-Electric-Racing/#115-duplicate-file-names

    #115 - Duplicate File Names

commit c4214bc
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 19:02:42 2022 -0400

    #115 - Flattened ChangeRequestDetailsPage folder and updated jest.mock() calls

commit 89fb809
Merge: e8f5207 123b2d7
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 18:32:15 2022 -0400

    Merge branch 'develop' into #115-duplicate-file-names

    # Conflicts:
    #	src/frontend/src/pages/ProjectDetailPage/ProjectViewContainer/ProjectDetails.tsx

commit e8f5207
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 18:29:23 2022 -0400

    #115 - Added changes from #114

commit 123b2d7
Merge: b25e5fc 54b0b91
Author: James Chang-Davidson <51571627+jamescd18@users.noreply.github.com>
Date:   Fri Aug 12 18:03:03 2022 -0400

    Merge pull request #118 from Northeastern-Electric-Racing/#114-remove-unused-fields-project-details

    #114 removed expected progress and timeline status from project-details

commit 54b0b91
Author: Danwo0 <dan.junwoo.lee@gmail.com>
Date:   Fri Aug 12 17:48:20 2022 -0400

    #114 removed expected progress and timeline status from project-details

commit 1e91b8c
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 14:21:59 2022 -0400

    #115 - Update one more jest.mock() calls

commit b426029
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 14:15:30 2022 -0400

    #115 - Updated jest.mock() calls

commit 97eac80
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 14:04:10 2022 -0400

    #115 - Converted apis folder and relevant tests to PascalCase and updated jest.mock() calls

commit 342e31c
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 13:57:46 2022 -0400

    #115 - Converted test-support folder and relevant tests to PascalCase and updated jest.mock() calls

commit a722477
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 13:53:40 2022 -0400

    #115 - Converted utils folder and relevant tests to PascalCase and updated jest.mock() calls

commit 168eb87
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 13:50:15 2022 -0400

    #115 - Converted stylesheets folder and relevant tests to PascalCase and updated jest.mock() calls

commit db4effc
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 13:36:44 2022 -0400

    #115 - Converted layouts folder and relevant tests to PascalCase and updated jest.mock() calls

commit 0dac82e
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 13:30:41 2022 -0400

    #115 - Converted hooks folder and relevant tests to PascalCase and updated jest.mock() calls

commit 7fdec19
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 13:16:40 2022 -0400

    #115 - Converted components folder and relevant tests to PascalCase and updated jest.mock() calls

commit 1d097fb
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 13:11:06 2022 -0400

    #115 - Converted app folder and relevant tests to PascalCase and updated jest.mock() calls

commit a1c87d5
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 13:04:59 2022 -0400

    #115 - Converted pages folder and relevant tests to PascalCase and updated jest.mock() calls

commit b1d274b
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Fri Aug 12 08:56:30 2022 -0400

    #115 - Renamed duplicates and flattened folder structure appropriately

commit b25e5fc
Merge: 3212ae5 79f9538
Author: Anthony Bernardi <63663597+anthonybernardi@users.noreply.github.com>
Date:   Fri Aug 12 00:14:46 2022 -0400

    Merge pull request #4 from Northeastern-Electric-Racing/#3

    #3 - moving hooks and apis out

commit 3212ae5
Merge: 98ecc22 be047cf
Author: James Chang-Davidson <51571627+jamescd18@users.noreply.github.com>
Date:   Thu Aug 11 22:21:34 2022 -0400

    Merge pull request #113 from Northeastern-Electric-Racing/#779-stop-decimal-inputs-CR

commit be047cf
Author: Kevin Chen <kevinchen@Kevins-MacBook-Pro.local>
Date:   Thu Aug 11 22:06:24 2022 -0400

    added integer checks for budget and timeline impact inputs

commit 98ecc22
Merge: 2ae2982 8fd6fe7
Author: Anthony Bernardi <63663597+anthonybernardi@users.noreply.github.com>
Date:   Thu Aug 11 14:31:10 2022 -0400

    Merge pull request #8 from Northeastern-Electric-Racing/#6-tsconfig

    #6 - Updated tsconfig.build.json

commit 2ae2982
Merge: 670aac8 8ca5c8d
Author: Anthony Bernardi <63663597+anthonybernardi@users.noreply.github.com>
Date:   Thu Aug 11 14:25:08 2022 -0400

    Merge pull request #111 from Northeastern-Electric-Racing/#110

    #110 - added scripts

commit 670aac8
Merge: e24be27 ab1ff35
Author: Anthony Bernardi <63663597+anthonybernardi@users.noreply.github.com>
Date:   Thu Aug 11 14:20:57 2022 -0400

    Merge pull request #109 from Northeastern-Electric-Racing/#108

    #108 - css

commit 8ca5c8d
Author: anthonybernardi <anthony.bernardi09@gmail.com>
Date:   Thu Aug 11 14:19:24 2022 -0400

    #110 - added scripts

commit ab1ff35
Author: anthonybernardi <anthony.bernardi09@gmail.com>
Date:   Thu Aug 11 14:13:38 2022 -0400

    #108 - css

commit 8fd6fe7
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Thu Aug 11 12:44:48 2022 -0400

    #6 - included more exclusions

commit 8614477
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Thu Aug 11 12:40:17 2022 -0400

    #6 - Fixed file path

commit 572d60b
Author: Aritra (Ari) Saharay <80832201+Ari-S-123@users.noreply.github.com>
Date:   Thu Aug 11 12:36:37 2022 -0400

    #6 - Updated tsconfig.build.json

commit 79f9538
Author: anthonybernardi <anthony.bernardi09@gmail.com>
Date:   Thu Aug 11 12:00:11 2022 -0400

    #3 - imports be like

commit 03ab8d4
Author: anthonybernardi <anthony.bernardi09@gmail.com>
Date:   Thu Aug 11 11:53:04 2022 -0400

    #3 - moved everything around and fixed tests

commit 6fd8e20
Merge: 1445d69 e24be27
Author: Anthony Bernardi <bernardi.an@husky.neu.edu>
Date:   Wed Aug 10 23:53:10 2022 -0400

    Merge branch 'develop' into #3

commit 1445d69
Author: Anthony Bernardi <bernardi.an@husky.neu.edu>
Date:   Wed Aug 10 23:50:11 2022 -0400

    - #3 - initial movement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamescd18 jamescd18 jamescd18 approved these changes

@anthonybernardi anthonybernardi Awaiting requested review from anthonybernardi

Assignees

@glacierA glacierA

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change Requests - Stop Input of Decimal Numbers

2 participants

@glacierA @jamescd18