Skip to content

#1329 WP Form Refactor#1707

Merged
RChandler234 merged 12 commits intofeature/Workpackage-Form-Redesignfrom
#1329-wp-form-refactor
Nov 24, 2023
Merged

#1329 WP Form Refactor#1707
RChandler234 merged 12 commits intofeature/Workpackage-Form-Redesignfrom
#1329-wp-form-refactor

Conversation

@walker-sean
Copy link
Copy Markdown
Member

@walker-sean walker-sean commented Nov 14, 2023

Changes

Refactored the WP edit form to be used for both creation and editing and implemented in both places

Notes

Currently, a CR for a work package cannot be used to make a new one. Not sure if this is intended functionality or not.

Screenshots

Edit:
image
Create:
image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #1329

@walker-sean walker-sean changed the title #1329 mostly done #1329 WP Form Refactor Nov 19, 2023
@walker-sean walker-sean self-assigned this Nov 19, 2023
@walker-sean walker-sean marked this pull request as ready for review November 19, 2023 22:00
Comment thread src/frontend/src/pages/WorkPackageForm/EditWorkPackageForm.tsx Outdated
Comment thread src/frontend/src/pages/WorkPackageForm/WorkPackageForm.tsx Outdated
Comment thread src/frontend/src/pages/WorkPackageForm/WorkPackageForm.tsx Outdated
Comment thread src/frontend/src/pages/WorkPackageForm/WorkPackageFormView.tsx Outdated
Comment thread src/frontend/src/pages/WorkPackageForm/WorkPackageFormView.tsx Outdated
Copy link
Copy Markdown
Contributor

@RChandler234 RChandler234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another issue I ran into was the form doesn't use the new default values if you submit an edit, and then immediately go to edit again, but when you reload the page and come back it's fine. I'd imagine this is a problem with when the work package that's being used for default values is being fetched

Comment thread src/frontend/src/pages/WorkPackageForm/WorkPackageFormView.tsx Outdated
Comment thread src/frontend/src/pages/WorkPackageForm/WorkPackageFormView.tsx
Copy link
Copy Markdown
Contributor

@RChandler234 RChandler234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lead/manager are not updating on edit, also getting an error when I try to create a WP with deliverables/ expected activities in the create form

@RChandler234 RChandler234 merged commit 95c2263 into feature/Workpackage-Form-Redesign Nov 24, 2023
@RChandler234 RChandler234 deleted the #1329-wp-form-refactor branch November 24, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants