#1329 WP Form Refactor#1707
Merged
RChandler234 merged 12 commits intofeature/Workpackage-Form-Redesignfrom Nov 24, 2023
Merged
Conversation
RChandler234
requested changes
Nov 20, 2023
Contributor
RChandler234
left a comment
There was a problem hiding this comment.
another issue I ran into was the form doesn't use the new default values if you submit an edit, and then immediately go to edit again, but when you reload the page and come back it's fine. I'd imagine this is a problem with when the work package that's being used for default values is being fetched
RChandler234
requested changes
Nov 21, 2023
RChandler234
requested changes
Nov 22, 2023
RChandler234
approved these changes
Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Refactored the WP edit form to be used for both creation and editing and implemented in both places
Notes
Currently, a CR for a work package cannot be used to make a new one. Not sure if this is intended functionality or not.
Screenshots
Edit:


Create:
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #1329